From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 543B4A0471 for <public@inbox.dpdk.org>; Thu, 18 Jul 2019 16:43:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2C3F91B951; Thu, 18 Jul 2019 16:43:27 +0200 (CEST) Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id 533C52BC7 for <dev@dpdk.org>; Thu, 18 Jul 2019 16:43:23 +0200 (CEST) Received: by mail-pl1-f196.google.com with SMTP id ay6so14008877plb.9 for <dev@dpdk.org>; Thu, 18 Jul 2019 07:43:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=db3L3Kylkh2gCSK5E9qIT/fwdZwTmE9pI9c/NSt+hic=; b=Sk45RhGkye671NlW+5yJ43rOJaYhKQlZ7AYTDxjnpvsneZYWdmNIpcOMI2+dVYI9D2 WTvBw2N1eXJXAQIWD8H9VISeUGlv1/WAfav6/+p+6LGw2YapgohR59oOb0WQxbytPC+r nGNXWDutkYmCGHAyQzm6SeGLidZaKTz14w9PoIX6k6Rs1L4AYwaz89j0oLDEiexB9xgM nSF1/MbFESsHO3VzlytOuCNysCXNbU9bV7a2OqOIYL9S+SAMYIkPmBNY31YmXdr83LKd 33S3Fo03n17rNWC7kIp0OupSFzJGmULxjZFKNQ/KR28e5n/FyMN1A7YBP08LyaGIcPrS xzhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=db3L3Kylkh2gCSK5E9qIT/fwdZwTmE9pI9c/NSt+hic=; b=A08L6JLJBuAuI6aS9nPlmXtSFmP6k44iFigu2/qmXtDsa9CIsxhafHeiSWs4Ujjj8Y 4ZwT3440Rou3Dt+6Xwm7AjQOzwg73pp1B/XJue93GqjTZzIbVT9lKGJGL/e1Xl620p5P M/CaDZffkS0ZtNmNsOxf3bNlbp7M/DxMe1XxGXa6KEVn95v2HsT2t/ELT0X+yLSklHeD jJarKAbcnvwe49cUggEerYmc9B38+Q/KNzE0Yocpyh1reLfyEIx3YnohYJ31GFifB2yd 7O/aP+3RscaIR2SiQWoPRz1ChQe5Sy3ld7ClS7eokDlK7PE1bglS+xlBDMd7ZkR+ocBy tacA== X-Gm-Message-State: APjAAAUv2Iyj752Gvw5ZxPv/5PzRUv2ongaHQrZSH/+XWqPROEhLvJHR gtPqDqAZgqGdCSkPdfRTX7E= X-Google-Smtp-Source: APXvYqzPJWTUsBGzyjNolwNKxyULtdlch4t3uVj9Tud3TiA0jKmmGUmF9jE9NYoLoFiCmzvdMzvU0A== X-Received: by 2002:a17:902:968d:: with SMTP id n13mr2614123plp.257.1563461002527; Thu, 18 Jul 2019 07:43:22 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id f15sm28570111pje.17.2019.07.18.07.43.22 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 18 Jul 2019 07:43:22 -0700 (PDT) Date: Thu, 18 Jul 2019 07:43:20 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: <pbhagavatula@marvell.com> Cc: <jerinj@marvell.com>, Nithin Dabilpuram <ndabilpuram@marvell.com>, "Vamsi Attunuru" <vattunuru@marvell.com>, <dev@dpdk.org> Message-ID: <20190718074320.0571e83f@hermes.lan> In-Reply-To: <20190717184013.1072-1-pbhagavatula@marvell.com> References: <20190717184013.1072-1-pbhagavatula@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] mempool/octeontx2: use noinline to preserve ABI X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Thu, 18 Jul 2019 00:10:13 +0530 <pbhagavatula@marvell.com> wrote: > From: Pavan Nikhilesh <pbhagavatula@marvell.com> > > Since direct register access is used in npa_lf_aura_op_alloc_bulk() > use __rte_noinline to preserve ABI. > > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com> Huh? this is an internal function, and the driver is new to DPDK. We don't maintain ABI with external drivers or code bases. And ABI with code before it was upstream doesn't count either.