From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 82E5DA0471 for ; Thu, 18 Jul 2019 19:13:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 77EE31DBE; Thu, 18 Jul 2019 19:12:59 +0200 (CEST) Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id 21E8614E8 for ; Thu, 18 Jul 2019 19:12:58 +0200 (CEST) Received: by mail-pg1-f193.google.com with SMTP id n9so6959619pgc.1 for ; Thu, 18 Jul 2019 10:12:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nYFWXonqKtk20NTtvk41RPLX07XU1IJcdmyslWDVErg=; b=Mwr6FVakujRnoZlhESikoFpHiJt5ZMlNeaFuH3GyKvrvvxuxOk34QF84N2PI5blwfv xijQukgx2SkV2MPmGlVmYHEmLl0HxXCfiptBfviLzC0RDbzdeawGxczrj9tmlhd1TuAW 5yQmxgREo9O+T4auMxscBfYrtptMV5jgmS0UThba8fReMQ/ZmAzT6IGMwmlitNZsq6+O lGgzvDR6hvk9uYyc4I538R5RpMK5ZES5DYs5cjePktH1sNdfVAnX7BHkK0EaRe9GBkZC zlm1GpxfaM0d7vbiSJ2W6PtF4ZvkVL7GVpMH4FrltzlCz7uTxMXFoEsmnPmaId3pCrjG hdKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nYFWXonqKtk20NTtvk41RPLX07XU1IJcdmyslWDVErg=; b=Rh0NlbwZnGg/wPCCGkITrkJpdcj5svLLtiZZIkqFib28nIj0r9rf1vWVzdTq61GYBK vVuBV+WVKX1KQqqWF8PO2v0yBPs6E9DZzAwFtGJfuAuGudVY0fcIw+sUoSEkXSfC1V3Z 8rXzXJZUKykrLyB5OY8Bx64Obk1KdLTOuGHrpXmpn1wXSOYhtQ8dnBI9HZIk1pMxOzzC qivk69qoHiDsDy5td71nWCZ336KBbkrJymuS2b22CPUoa68mOebxALebd5JvQKeepzwF vm7qXysIZNFzJWpoGtsRv0+rmj6LyZCjhN7EEoqjhlGMGTK4ITJggRHIo6ill2pgbMNc PDFw== X-Gm-Message-State: APjAAAVCwno7g+JgfHBtsDEnXqAIlYkidNoKQLsTR+0QHVPEE4+BFcjQ gYyY6UlLBsWIoKk6ZgmNdrU= X-Google-Smtp-Source: APXvYqxU05rX/UAKhe2h3f3LfjlzqmWh/D6DpgGZ3dGicJtukLh6mYJk22bFtMfBROLLYzFMnkUqfQ== X-Received: by 2002:a65:5584:: with SMTP id j4mr18590544pgs.258.1563469976740; Thu, 18 Jul 2019 10:12:56 -0700 (PDT) Received: from xps13 ([67.23.203.6]) by smtp.gmail.com with ESMTPSA id z20sm47817489pfk.72.2019.07.18.10.12.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 18 Jul 2019 10:12:56 -0700 (PDT) Date: Thu, 18 Jul 2019 10:12:53 -0700 From: Stephen Hemminger To: Bruce Richardson Cc: dev@dpdk.org Message-ID: <20190718101253.0fdfca3d@xps13> In-Reply-To: <20190718143645.GA1641@bricha3-MOBL.ger.corp.intel.com> References: <20190716172741.21399-1-stephen@networkplumber.org> <20190718004822.25431-1-stephen@networkplumber.org> <20190718004822.25431-3-stephen@networkplumber.org> <20190718083111.GA1325@bricha3-MOBL.ger.corp.intel.com> <20190718073459.3004bb39@hermes.lan> <20190718143645.GA1641@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 2/3] cfgfile: use RTE_LOG for errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 18 Jul 2019 15:36:45 +0100 Bruce Richardson wrote: > On Thu, Jul 18, 2019 at 07:34:59AM -0700, Stephen Hemminger wrote: > > On Thu, 18 Jul 2019 09:31:11 +0100 > > Bruce Richardson wrote: > > > > > On Wed, Jul 17, 2019 at 05:48:21PM -0700, Stephen Hemminger wrote: > > > > In general, DPDK libraries to not print error messages to > > > > stdout because that is often redirected to /dev/null for daemons. > > > > This patch changes cfgfile library to use RTE_LOG with its > > > > own type. > > > > > > > > Signed-off-by: Stephen Hemminger > > > > --- > > > > lib/librte_cfgfile/Makefile | 1 + > > > > lib/librte_cfgfile/rte_cfgfile.c | 38 +++++++++++++++++++++++--------- > > > > 2 files changed, 29 insertions(+), 10 deletions(-) > > > > > > > > diff --git a/lib/librte_cfgfile/Makefile b/lib/librte_cfgfile/Makefile > > > > index d9512565e559..4fc711778699 100644 > > > > --- a/lib/librte_cfgfile/Makefile > > > > +++ b/lib/librte_cfgfile/Makefile > > > > @@ -11,6 +11,7 @@ LIB = librte_cfgfile.a > > > > CFLAGS += -O3 > > > > CFLAGS += $(WERROR_FLAGS) > > > > CFLAGS += -I$(SRCDIR)/../librte_eal/common/include > > > > +LDFLAGS += -lrte_log > > > > > > > Where does this come from, there is no separate log library in DPDK? > > > > I saw a build failure with previous patch about rte_log not being > > present. > > I can believe that, it's just how does this help? What does the linker pick > up when you pass this? Not sure what causes this: *Make Build Failed #1: OS: RHEL80-64 Target: x86_64-native-linuxapp-gcc+shared rte_cfgfile.o:rte_cfgfile.c:(.text.unlikely+0xbe): more undefined references to `rte_log' follow rte_cfgfile.o: In function `cfgfile_init': rte_cfgfile.c:(.text.startup+0xc): undefined reference to `rte_log_register' rte_cfgfile.c:(.text.startup+0x25): undefined reference to `rte_log_set_level' collect2: error: ld returned 1 exit status make[5]: *** [/tmp/RHEL80-64_K3.10.0_GCC8.2.1/x86_64-native-linuxapp-gcc+shared/6baa0548e7644f418e02f19043f86f82/dpdk/mk/rte.lib.mk:102: librte_cfgfile.so.2.1] Error 1 make[4]: *** [/tmp/RHEL80-64_K3.10.0_GCC8.2.1/x86_64-native-linuxapp-gcc+shared/6baa0548e7644f418e02f19043f86f82/dpdk/mk/rte.subdir.mk:37: librte_cfgfile] Error 2 make[4]: *** Waiting for unfinished jobs.... == Build lib/librte_eal/common SYMLINK-FILE include/rte_common.h SYMLINK-FILE include/rte_compat.h SYMLINK-FILE include/rte_branch_prediction.h --