From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0496DA0471 for ; Thu, 18 Jul 2019 08:27:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E0B4E1D9E; Thu, 18 Jul 2019 08:27:36 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id CB8021B53 for ; Thu, 18 Jul 2019 08:27:34 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jul 2019 23:27:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,276,1559545200"; d="scan'208";a="195507602" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.185]) by fmsmga002.fm.intel.com with ESMTP; 17 Jul 2019 23:27:32 -0700 Date: Thu, 18 Jul 2019 21:09:07 +0800 From: Ye Xiaolong To: taox.zhu@intel.com Cc: beilei.xing@intel.com, qi.z.zhang@intel.com, dev@dpdk.org Message-ID: <20190718130907.GB88943@intel.com> References: <20190718145351.13987-1-taox.zhu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190718145351.13987-1-taox.zhu@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix request queue fail in VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 07/18, taox.zhu@intel.com wrote: >From: Zhu Tao > >When the VF configuration is larger than the number of queues reserved >by PF, VF sends the request queue command through admin queue. When PF >received this command, it may reset the VF and send a notification >before resetting. If this notification is read by the timed task alarm, >Task request queue will lost notification. This patch Mark vf_reset, >pend_msg flag just as task request queue has received notification in >task alarm. Please add fixes tag and cc stable. Thanks, Xiaolong > >Signed-off-by: Zhu Tao >--- > drivers/net/i40e/i40e_ethdev_vf.c | 4 ++++ > 1 file changed, 4 insertions(+) > >diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c >index 5be32b069..86dfda1c0 100644 >--- a/drivers/net/i40e/i40e_ethdev_vf.c >+++ b/drivers/net/i40e/i40e_ethdev_vf.c >@@ -1332,6 +1332,10 @@ i40evf_handle_pf_event(struct rte_eth_dev *dev, uint8_t *msg, > PMD_DRV_LOG(DEBUG, "VIRTCHNL_EVENT_RESET_IMPENDING event"); > _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_RESET, > NULL); >+ if (vf->vf_reset == false) { >+ vf->vf_reset = true; >+ vf->pend_msg |= PFMSG_RESET_IMPENDING; >+ } > break; > case VIRTCHNL_EVENT_LINK_CHANGE: > PMD_DRV_LOG(DEBUG, "VIRTCHNL_EVENT_LINK_CHANGE event"); >-- >2.17.1 >