DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [EXT] [PATCH] net/octeontx: use logtype_init for failed probe
Date: Fri, 19 Jul 2019 09:59:06 -0700	[thread overview]
Message-ID: <20190719095906.7e7b1473@hermes.lan> (raw)
In-Reply-To: <BYAPR18MB2424382DC2A8450216CD2D74C8CB0@BYAPR18MB2424.namprd18.prod.outlook.com>

On Fri, 19 Jul 2019 03:37:26 +0000
Jerin Jacob Kollanukkaran <jerinj@marvell.com> wrote:

> > -----Original Message-----
> > From: Stephen Hemminger <stephen@networkplumber.org>
> > Sent: Wednesday, July 17, 2019 12:18 AM
> > To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> > Cc: dev@dpdk.org
> > Subject: [EXT] [PATCH] net/octeontx: use logtype_init for failed probe  
> 
> > All log messages should use driver logtype. RTE_LOGTYPE_PMD is planned to
> > be deprecated in the future.
> > 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---  
> 
> Please fix
> 
> $ ./devtools/check-git-log.sh
> Wrong headline format:
>         net/octeontx: use logtype_init for failed probe
> 		

OK but

That rule in check-git-log is still ridiculous because it rejects perfectly good
commit subjects. The intention is good "stop automated bots" but the implementation
rejects too many good patches.

  reply	other threads:[~2019-07-19 16:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-16 18:47 [dpdk-dev] " Stephen Hemminger
2019-07-19  3:37 ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran
2019-07-19 16:59   ` Stephen Hemminger [this message]
2019-07-22  8:05     ` Jerin Jacob Kollanukkaran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190719095906.7e7b1473@hermes.lan \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).