DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] pci: fix missing pci bus with shared library build
Date: Mon, 22 Jul 2019 11:53:26 -0700	[thread overview]
Message-ID: <20190722115326.25a201b8@xps13> (raw)
In-Reply-To: <4987111.cxvgFvst8F@xps>

On Mon, 22 Jul 2019 19:31:08 +0200
Thomas Monjalon <thomas@monjalon.net> wrote:

> 22/07/2019 19:13, Stephen Hemminger:
> > Thomas Monjalon <thomas@monjalon.net> wrote:  
> > > Are the constructors run on dlopen of the bus driver?  
> > 
> > Yes, constructors are run on dlopen.
> > But application should not have to ask DPDK to dlopen the bus devices.
> > 
> > The core principle is that dynamic build of DPDK should act the same as old
> > statically linked DPDK. Otherwise, the user experience is even worse, and all
> > the example documentation is wrong.  
> 
> OK, this is where I wanted to bring the discussion.
> You are arguing against a design which is in DPDK from some early days.
> So this is an interesting discussion to have.
> Do we want to change the "plugin model" we have?
> Or do we want to simply drop this model (dlopen calls)
> and replace it with strong dynamic linking?
> 
> 

What I think should happen (and isn't is):

1. The PCI bus library is linked with --whole-archive, and --no-as-needed.
   This causes constructor to be called and register the bus.

2. As part of the build process all the PCI drivers pmdinfo would get
   constructed into a table of vendor/device to PMD shared library name.

3. PMD's are linked as --whole-archive, and --as-needed.

4. New code in PCI probe which looks for existing entries (static or -d)
   for devices. If device is still not found it refers to the table of PMD's
   (from #2) and calls dlopen for that device (and adds it to static table).

This would allow examples and customer applications to Just Work without
having to know the PMD that is present. It would also solve the problem
that currently if applications is linked with -ldpdk linker script then
all PMD's get pulled into the application address space.




  parent reply	other threads:[~2019-07-22 18:53 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-15 23:41 Stephen Hemminger
2019-07-16  0:16 ` Stephen Hemminger
2019-07-16  0:19 ` Stephen Hemminger
2019-07-16  8:46   ` Bruce Richardson
2019-07-16 14:46     ` Stephen Hemminger
2019-07-19 18:11     ` Stephen Hemminger
2019-07-19 20:39     ` Stephen Hemminger
2019-07-19 20:55     ` Stephen Hemminger
2019-07-22  7:38       ` Thomas Monjalon
2019-07-22  9:06         ` Bruce Richardson
2019-07-22 16:43           ` Stephen Hemminger
2019-07-22 17:04             ` Thomas Monjalon
2019-07-22 17:13               ` Stephen Hemminger
2019-07-22 17:31                 ` Thomas Monjalon
2019-07-22 18:34                   ` Stephen Hemminger
2019-07-23  7:59                     ` Thomas Monjalon
2019-07-23 18:29                       ` Stephen Hemminger
2019-07-23 18:35                         ` Thomas Monjalon
2019-07-22 18:53                   ` Stephen Hemminger [this message]
2019-07-23 12:30                     ` Bruce Richardson
2019-07-23 18:11                       ` Stephen Hemminger
2019-07-24  8:56                         ` Bruce Richardson
2019-07-23 18:47                       ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190722115326.25a201b8@xps13 \
    --to=stephen@networkplumber.org \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).