From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Haiyue Wang <haiyue.wang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v1] net/ice: remove unnecessary type cast in rx/tx ring setup
Date: Wed, 24 Jul 2019 16:17:37 +0800 [thread overview]
Message-ID: <20190724081737.GA72232@intel.com> (raw)
In-Reply-To: <1563929545-25010-1-git-send-email-haiyue.wang@intel.com>
On 07/24, Haiyue Wang wrote:
>The memzone's start virtual address pointer (addr) is of type void *,
>no need to add type cast.
>
>Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
>---
> drivers/net/ice/ice_rxtx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
>index 3353f23..0282b53 100644
>--- a/drivers/net/ice/ice_rxtx.c
>+++ b/drivers/net/ice/ice_rxtx.c
>@@ -664,7 +664,7 @@ ice_rx_queue_setup(struct rte_eth_dev *dev,
> memset(rz->addr, 0, ring_size);
>
> rxq->rx_ring_dma = rz->iova;
>- rxq->rx_ring = (union ice_rx_desc *)rz->addr;
>+ rxq->rx_ring = rz->addr;
>
> #ifdef RTE_LIBRTE_ICE_RX_ALLOW_BULK_ALLOC
> len = (uint16_t)(nb_desc + ICE_RX_MAX_BURST);
>@@ -882,7 +882,7 @@ ice_tx_queue_setup(struct rte_eth_dev *dev,
> txq->tx_deferred_start = tx_conf->tx_deferred_start;
>
> txq->tx_ring_dma = tz->iova;
>- txq->tx_ring = (struct ice_tx_desc *)tz->addr;
>+ txq->tx_ring = tz->addr;
>
> /* Allocate software ring */
> txq->sw_ring =
>--
>2.7.4
>
Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
next prev parent reply other threads:[~2019-07-24 1:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 0:52 Haiyue Wang
2019-07-24 8:17 ` Ye Xiaolong [this message]
2019-07-24 13:02 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724081737.GA72232@intel.com \
--to=xiaolong.ye@intel.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).