From: John Daley <johndale@cisco.com>
To: ferruh.yigit@intel.com
Cc: hyonkim@cisco.com, dev@dpdk.org, John Daley <johndale@cisco.com>
Subject: [dpdk-dev] [PATCH v2] net/enic: retain previous message logging
Date: Fri, 26 Jul 2019 13:12:46 -0700 [thread overview]
Message-ID: <20190726201246.26234-1-johndale@cisco.com> (raw)
In-Reply-To: <20190725024619.26040-1-johndale@cisco.com>
Prior to the fix, RTE_LOGTYPE_INFO messages were displayed by default.
After the fix, only NOTICE level and higher were displayed by default
and INFO level were not. There are INFO level vNIC config related
messages which customers and tech support currently depend on for
debugging and so on and to suddenly hide these messages is not a good
idea.
This patch changes the default log level to RTE_LOG_INFO for enic so
messages are printed as before the fix.
Fixes: bbd8ecc05434 ("net/enic: remove PMD log type references")
Signed-off-by: John Daley <johndale@cisco.com>
---
v2: Change default log level to 'RTE_LOG_INFO' instead of changing the
'dev_info' messages to 'dev_notice'
drivers/net/enic/enic_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethdev.c
index 6051689a6..0ade57370 100644
--- a/drivers/net/enic/enic_ethdev.c
+++ b/drivers/net/enic/enic_ethdev.c
@@ -73,7 +73,7 @@ RTE_INIT(enicpmd_init_log)
{
enic_pmd_logtype = rte_log_register("pmd.net.enic");
if (enic_pmd_logtype >= 0)
- rte_log_set_level(enic_pmd_logtype, RTE_LOG_NOTICE);
+ rte_log_set_level(enic_pmd_logtype, RTE_LOG_INFO);
}
static int
--
2.22.0
next prev parent reply other threads:[~2019-07-26 20:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 2:46 [dpdk-dev] [PATCH] " John Daley
2019-07-25 10:07 ` Ferruh Yigit
2019-07-25 20:25 ` John Daley (johndale)
2019-07-26 4:21 ` Hyong Youb Kim (hyonkim)
2019-07-26 9:51 ` Ferruh Yigit
2019-07-26 20:50 ` Stephen Hemminger
2019-07-26 21:15 ` John Daley (johndale)
2019-07-26 8:17 ` John Daley (johndale)
2019-07-26 10:00 ` Ferruh Yigit
2019-07-26 20:06 ` John Daley (johndale)
2019-07-26 20:12 ` John Daley [this message]
2019-07-29 11:03 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190726201246.26234-1-johndale@cisco.com \
--to=johndale@cisco.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=hyonkim@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).