From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E213A0487 for ; Mon, 29 Jul 2019 17:25:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 04CB71BFB8; Mon, 29 Jul 2019 17:25:43 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 4E3B51BF71 for ; Mon, 29 Jul 2019 17:25:42 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jul 2019 08:25:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,323,1559545200"; d="scan'208";a="371097433" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.185]) by fmsmga006.fm.intel.com with ESMTP; 29 Jul 2019 08:25:39 -0700 Date: Mon, 29 Jul 2019 23:25:29 +0800 From: Ye Xiaolong To: Ferruh Yigit Cc: John McNamara , Marko Kovacevic , dev@dpdk.org Message-ID: <20190729152529.GA113876@intel.com> References: <20190724153541.101034-1-xiaolong.ye@intel.com> <8d9e7b3c-ca5c-5727-8095-6ea35c7f701e@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8d9e7b3c-ca5c-5727-8095-6ea35c7f701e@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [RFC] kni: support allmulticast mode set X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Ferruh On 07/29, Ferruh Yigit wrote: >On 7/24/2019 4:35 PM, Xiaolong Ye wrote: >> This patch adds support to allow users enable/disable allmulticast mode for >> kni interface. >> >> This requirement comes from bugzilla 312, more details can refer to: >> https://bugs.dpdk.org/show_bug.cgi?id=312 >> >> Bugzilla ID: 312 >> >> Signed-off-by: Xiaolong Ye > >Hi Xiaolong, > >Patch lgtm, I think it is too later for this release but I suggest sending v1 >for next release. Got it, this patch is not that urgent, we can wait for next release. > >If there is an ABI breakage, to not block the patch for next release, a >deprecation notice needs to be sent in this release. >Although the patch updates header file, as far as I can see it doesn't break the >ABI, since added fields either last element of the struct or the part of the >union. But to be sure, can you please double check if I am missing something? I don't think there is an ABI break either, I'll double check it anyway. Thanks, Xiaolong