From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C08D1A0487 for ; Mon, 29 Jul 2019 23:28:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B3C931BF6B; Mon, 29 Jul 2019 23:28:14 +0200 (CEST) Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id 658991BF53 for ; Mon, 29 Jul 2019 23:28:13 +0200 (CEST) Received: by mail-pf1-f196.google.com with SMTP id u14so28682762pfn.2 for ; Mon, 29 Jul 2019 14:28:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id; bh=RsGBE3knoov8cvdYP8CdaxGzUrtQ8GIuIcwczJG0Xio=; b=FDGnodV5lhfSn2vLmTKOtWc7eFcMAAyot/uv0p67U7vRuPRsuvuZOCZoQeGW2wwE+L MbG7n2TSPbfld63UtV6teFJ2BUL1o1qNaAtkHaFrIrIsbf/47ZfgaD0s9qGn9l0vUKRc mLkETpM4HFHTye2OXVfrWZxdNGruOOBek4YBc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=RsGBE3knoov8cvdYP8CdaxGzUrtQ8GIuIcwczJG0Xio=; b=es4LAaGqk2VyANmqfzixRTM5cN9LXHHFZ4XKfuTmIR9n8WU3O5VOO2lRSdTCPyBFIP 5ICCjJVz16wLCnpSb4F7qtfc4nd4gdPW9fDMfIWcnmEwTzMPLxYtGxdT9qSfRzjXHD5P rBsIVv2RVB8WXDocH02JazkKu1NCwJEXQIYJ76vZLLt0sNp4lEYxF7lKjVLKLcHfeV9M o8CJ9yD+LJ+5H2mbQAgOsAsX5KlhnB3x6/CmuPCnG81gwvd6RehccxxhhONFCH1O+jqZ FO2oz6bmAdwUJoQCVksqXOoSG0XrnOprs7Zu1edDyJambveHCeGLebO7s9/jx0wl416r hBxg== X-Gm-Message-State: APjAAAW+Lx1/znBh9Ws+vkCJ7A58EyrqSfIYhJ6LoR5rJQJvj8Oereoi 0npGCwWM3nTqYwYbXjI3dh03+Ovcl3oByN8YifxfR65PLi9c0SRG+K8glbIiMcxIFS/xICingld /tbch1LmZhSqis3Ok6U+JyxdOJcPpNFhcgUskA2mNemElZLndAAE0TBjV9aMAeFCK X-Google-Smtp-Source: APXvYqyjY1NHVMjj+/f8LxhlcLH/aPYeChomJiWO+nDWo9Enffb6bTRsa3o50JWlSpU9miml2z8cJQ== X-Received: by 2002:a17:90a:b903:: with SMTP id p3mr112119577pjr.79.1564435692374; Mon, 29 Jul 2019 14:28:12 -0700 (PDT) Received: from localhost.localdomain ([192.19.231.250]) by smtp.gmail.com with ESMTPSA id l26sm64344428pgb.90.2019.07.29.14.28.10 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 29 Jul 2019 14:28:11 -0700 (PDT) From: Lance Richardson To: dev@dpdk.org Cc: ajit.khaparde@broadcom.com, Kalesh AP , Lance Richardson Date: Mon, 29 Jul 2019 17:28:05 -0400 Message-Id: <20190729212805.5026-1-lance.richardson@broadcom.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH 1/2] net/bnxt: fix context memory allocation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Kalesh AP There is a bug in context memory allocation because of which it results in reusing the context memory allocated for the first port while allocating memory for next ports. Fix it by passing the port id in the name field while allocating context memory. Fixes: f8168ca0e690 ("net/bnxt: support thor controller") Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Signed-off-by: Lance Richardson --- drivers/net/bnxt/bnxt_ethdev.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 2a8b50296..6685ee7d9 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -3399,8 +3399,9 @@ static int bnxt_alloc_ctx_mem_blk(__rte_unused struct bnxt *bp, valid_bits = PTU_PTE_VALID; if (rmem->nr_pages > 1) { - snprintf(mz_name, RTE_MEMZONE_NAMESIZE, "bnxt_ctx_pg_tbl%s_%x", - suffix, idx); + snprintf(mz_name, RTE_MEMZONE_NAMESIZE, + "bnxt_ctx_pg_tbl%s_%x_%d", + suffix, idx, bp->eth_dev->data->port_id); mz_name[RTE_MEMZONE_NAMESIZE - 1] = 0; mz = rte_memzone_lookup(mz_name); if (!mz) { @@ -3436,7 +3437,8 @@ static int bnxt_alloc_ctx_mem_blk(__rte_unused struct bnxt *bp, rmem->pg_tbl_mz = mz; } - snprintf(mz_name, RTE_MEMZONE_NAMESIZE, "bnxt_ctx_%s_%x", suffix, idx); + snprintf(mz_name, RTE_MEMZONE_NAMESIZE, "bnxt_ctx_%s_%x_%d", + suffix, idx, bp->eth_dev->data->port_id); mz = rte_memzone_lookup(mz_name); if (!mz) { mz = rte_memzone_reserve_aligned(mz_name, -- 2.17.1