From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 60ECDA0613 for <public@inbox.dpdk.org>; Tue, 30 Jul 2019 17:25:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DE8831C125; Tue, 30 Jul 2019 17:25:43 +0200 (CEST) Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by dpdk.org (Postfix) with ESMTP id A4FA01C066 for <dev@dpdk.org>; Tue, 30 Jul 2019 17:25:42 +0200 (CEST) Received: by mail-pf1-f171.google.com with SMTP id b13so30022666pfo.1 for <dev@dpdk.org>; Tue, 30 Jul 2019 08:25:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hYFOxkbi+AXgHy9o7F6dL6xN/ZPnIYYMgsSUf5LYNq4=; b=o5IOfrvoMMdt4+sxeHhGzCOb+rsvLe2kVw6lKlXGvRP7p+spkRaoRzYGQPcvJhAweV 7eWeNeupiHXeRFFAkU0JaTVwXNqXolnmxGaAUiEIkt6s1O93Ths6PWXJOb9ISCuNW78S BcWIdX7YJz6mAkVotpHm3UICFajgoz6rzplCgpJshglQ13chG8n8WLJFdJl91hvxzr8a xWIDvlTXdyd7Zs+eUUtsb6Mq2eiX3D0IcTnxtxnj3/BnrHvmlQkEkyXsE0phhwLm6352 Tn7lbO7DwoVyjbifzsRUgUPVePkhmftl7y1NU5dOAqYCN+2dEaUUkwqaX1RdCmnZLux6 Fbkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hYFOxkbi+AXgHy9o7F6dL6xN/ZPnIYYMgsSUf5LYNq4=; b=nGDBIMrkPIxnl7RFE3HESEmc8ZHRXQ4g4K5/4FSz52e9GnmqkLSaYjD0zACC7+BIc5 q81fm6jT2eANQ493U9wn3Hk8/jcB38/2ga1b5uiIFaPIWicWXntxzVxk05edZj/oPJYr SvCVAJp4EBZZqLdcqySX4F2yCs7SfIWwgsfupWYzuGo1YIs35EdhsZr63tNFeYNhVSlf fLmqAWs4Q42amVxRocsXdq9t8ToGbGEf6fCmYf9bWMVtn9j1ECjfI9cO1rmkWHQ6PM6w dh6s/IyblK3HcAHTkZCBsH94QwPMUxoldYBfzl2nL/ziRUDv8x37qvlGTeVdo6131SR7 2WVQ== X-Gm-Message-State: APjAAAUvEjXbb6/7hRSmbBSAkrEv4lcvQHSXm7/kWVWudsRQyqV7l7l1 NqBVDiq58WxJURH0IMxeZ/+F02po X-Google-Smtp-Source: APXvYqx8dZANsGeqrjeP8QsoFITein9+8n59dS37PIzhhGk9eEpQF7lWfQaxYN1DDhyz5lDtZXg9mA== X-Received: by 2002:a63:5d54:: with SMTP id o20mr93311221pgm.413.1564500341677; Tue, 30 Jul 2019 08:25:41 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id a21sm73932481pfi.27.2019.07.30.08.25.41 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 30 Jul 2019 08:25:41 -0700 (PDT) Date: Tue, 30 Jul 2019 08:25:34 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: Marcin Zapolski <marcinx.a.zapolski@intel.com> Cc: dev@dpdk.org Message-ID: <20190730082534.7f2138ee@hermes.lan> In-Reply-To: <20190730124950.1293-2-marcinx.a.zapolski@intel.com> References: <20190730124950.1293-1-marcinx.a.zapolski@intel.com> <20190730124950.1293-2-marcinx.a.zapolski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC 19.11 1/2] ethdev: make DPDK core functions non-inline X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Tue, 30 Jul 2019 14:49:49 +0200 Marcin Zapolski <marcinx.a.zapolski@intel.com> wrote: > Make rte_eth_rx_burst, rte_eth_tx_burst and other static inline ethdev > functions not inline. They are referencing DPDK internal structures and > inlining forces those structures to be exposed to user applications. > > In internal testing with i40e NICs a performance drop of about 2% was > observed with testpmd. > > Signed-off-by: Marcin Zapolski <marcinx.a.zapolski@intel.com> Sorry 2% matters.