From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C3039A0613 for ; Tue, 30 Jul 2019 17:50:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2AF011BEF1; Tue, 30 Jul 2019 17:50:16 +0200 (CEST) Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id B3A431BED1 for ; Tue, 30 Jul 2019 17:50:14 +0200 (CEST) Received: by mail-pf1-f193.google.com with SMTP id y15so30064123pfn.5 for ; Tue, 30 Jul 2019 08:50:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WzizDNPXZIXmxP3YkiUcCVkSvwYz2pqGImJrC2EIJRQ=; b=mTWcU5HRpxCZ8EWauO+2ibZzerh1X97rkGJ9fG5Xg4mJcnOVHXtOWo3L4r2pQvZq4W BTr5t3CDyxZuVoRB6xjCtqGzYJsrfCGK9NbanDL6tGi2Ox3TQH3kRW29ed/GyA66D+G0 +MfOxrWJAQarLCpLtidmwAqLkCoNerjhM4yYz8En2K/W7IMov73aHyQSwTwdKZd5xNMU JJfe+tZNmIcI4e2Az47r0C+Egx3ZptgNNC3n4ptFyvubsOyuWub9KlUBC1bDMdf++zd7 wVO6LrnJ/XhOR7aHQzcBUjovyzkQtH0w6pTfLEyw0vPymC39PSFU63uC+9QOyzJTVJXf zOug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WzizDNPXZIXmxP3YkiUcCVkSvwYz2pqGImJrC2EIJRQ=; b=tF2vjxD5ynw/hv24rQYraGzkHsGCtp2DtgaDpxTfUQR33LYI5MyHQDHcLXZz24jqSj EN3H0YE/nd49wrz0by/TdqIY3Z2ef8GbdjDKrA7xuFZlJeuM2NFoKAG6Ti+Y46TunNaH BMisfhMJfmQYgjjfDFKvFlcBCWAWpa8XNYn2MoTEPy9FHN2xjp2VbuUpruVN105LMVtb MAxiFXW0VCLxqkgyyDTVBYvf9HAsTrptmSs3eUD/yxIs4jla3A6nWLMZIrMROScSpBk6 WDh4ivBRADhtnyG3Lzhm2LZNe+70C49QWgoBdj7wxze0s1akG1BxEE2KFBt1a23oZ4Gt ZqbA== X-Gm-Message-State: APjAAAVSSxGx+ID4vAb0TNZWtcGLHnH+b4fZN7ZxNf+PY/oH0TdK9vvc /bo7NM/xfCMQjXj+fd2JN8o= X-Google-Smtp-Source: APXvYqy5+2pMSuGHmAiCQaWWMLF5c0SGX4Nk0JtIeTduhKEMPDynZx52rB3+BIrvnGk0XqC5RY7yfQ== X-Received: by 2002:a63:bf01:: with SMTP id v1mr107140666pgf.278.1564501813738; Tue, 30 Jul 2019 08:50:13 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id 65sm68616662pgf.30.2019.07.30.08.50.13 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 30 Jul 2019 08:50:13 -0700 (PDT) Date: Tue, 30 Jul 2019 08:50:07 -0700 From: Stephen Hemminger To: simei Cc: qi.z.zhang@intel.com, jingjing.wu@intel.com, adrien.mazarguil@6wind.com, dev@dpdk.org Message-ID: <20190730085007.23775125@hermes.lan> In-Reply-To: <1564101350-98092-1-git-send-email-simei.su@intel.com> References: <1564054620-43179-1-git-send-email-simei.su@intel.com> <1564101350-98092-1-git-send-email-simei.su@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC,v2] ethdev: extend RSS offload types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 26 Jul 2019 08:35:50 +0800 simei wrote: > From: Simei Su > > This RFC reserves several bits as input set selection from bottom > of the 64 bits. The flow type is combined with input set to > represent rss types. > > Correct the input set mask to align with the definition in rte_ethdev.h. > for example: > ETH_RSS_IPV4 | ETH_RSS_INSET_L3_SRC: hash on src ip address only > ETH_RSS_IPV4_UDP | ETH_RSS_INSET_L4_DST: hash on src/dst IP and > dst UDP port > ETH_RSS_L2_PAYLOAD | ETH_RSS_INSET_L2_DST: hash on dst mac address > > Signed-off-by: Simei Su NAK to any patch that "reserves" bits for future use. Please include the patch as part of a set of patches that actually implements the functionality on a device.