From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 04905A0487 for ; Tue, 30 Jul 2019 11:42:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 001CA1C030; Tue, 30 Jul 2019 11:42:15 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id DE7291C02E for ; Tue, 30 Jul 2019 11:42:14 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jul 2019 02:42:13 -0700 X-IronPort-AV: E=Sophos;i="5.64,326,1559545200"; d="scan'208";a="165794240" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.61]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jul 2019 02:42:11 -0700 Date: Tue, 30 Jul 2019 10:42:02 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, shreyansh.jain@nxp.com, hemant.agrawal@nxp.com, david.marchand@redhat.com, Neil Horman Message-ID: <20190730094201.GA1641@bricha3-MOBL.ger.corp.intel.com> References: <20190705093401.69913-1-bruce.richardson@intel.com> <2033098.zfnWnl858g@xps> <1605498.ZGlQ3oZTaz@xps> <3048859.hlssD6FjPI@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3048859.hlssD6FjPI@xps> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [RFC PATCH 0/2] standardize rawdev names X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jul 30, 2019 at 10:17:46AM +0200, Thomas Monjalon wrote: > 05/07/2019 11:39, Thomas Monjalon: > > 05/07/2019 11:38, Thomas Monjalon: > > > 05/07/2019 11:35, Bruce Richardson: > > > > On Fri, Jul 05, 2019 at 10:33:59AM +0100, Bruce Richardson wrote: > > > > > The names of the rawdev drivers and the resultant libraries they built > > > > > were pretty inconsistent. In terms of directory names, some had "rawdev" > > > > > in the name, e.g. skeleton_rawdev, ifpga_rawdev, while others didn't. > > > > > Also, for the built .so/.a libraries, the names were not always > > > > > consistent between make and meson, as, while meson enforced a consistent > > > > > naming scheme, make did not, leading to differences - especially for > > > > > those drivers with "rawdev" in the directory name. > > > > > > > > > > This patchset attempts to make things more standardized by removing > > > > > "rawdev" from all directory names - the drivers are in the "drivers/raw" > > > > > directory after all - and then standardizing the library names to > > > > > "librte_rawdev_" for both make and meson. > > > > > > > > > > Bruce Richardson (2): drivers/raw: remove rawdev from driver directory > > > > > names drivers/raw: standardize name format of rawdev drivers > > > > > > > > > Since the .so/.a files we produce are changing, would this patchset - if > > > > accepted - need a deprecation notice in 19.08 for a future 19.11 merge? > > > > > > I would say we can merge it in 19.08 without prior notice. > > > Any other opinion? > > > > Cc Neil > > We got no more opinion. > Does it mean I can merge it in 19.08-rc3? > Seems like it should be safe enough to me. Rawdevs are pretty new and not that widely used, I suspect. Any issues that do arise with the rename can be resolved via symlink, so the risk is low, I suspect. Regards, /Bruce