From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 933DEA0487
for <public@inbox.dpdk.org>; Tue, 30 Jul 2019 11:47:31 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 7564F1C0C0;
Tue, 30 Jul 2019 11:47:31 +0200 (CEST)
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
by dpdk.org (Postfix) with ESMTP id 9D6C21C0AA;
Tue, 30 Jul 2019 11:47:29 +0200 (CEST)
X-Amp-Result: UNSCANNABLE
X-Amp-File-Uploaded: False
Received: from orsmga008.jf.intel.com ([10.7.209.65])
by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
30 Jul 2019 02:47:28 -0700
X-IronPort-AV: E=Sophos;i="5.64,326,1559545200"; d="scan'208";a="165795285"
Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.61])
by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
30 Jul 2019 02:47:24 -0700
Date: Tue, 30 Jul 2019 10:47:21 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, stable@dpdk.org,
hgovindh <hariprasad.govindharajan@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>, Ori Kam <orika@mellanox.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>,
Radu Nicolau <radu.nicolau@intel.com>, Akhil Goyal <akhil.goyal@nxp.com>,
Tomasz Kantecki <tomasz.kantecki@intel.com>, drc@linux.vnet.ibm.com,
ruifeng.wang@arm.com, maciej.czekaj@caviumnetworks.com
Message-ID: <20190730094721.GB1641@bricha3-MOBL.ger.corp.intel.com>
References: <20190726132758.55217-1-hariprasad.govindharajan@intel.com>
<20190726135858.55792-1-hariprasad.govindharajan@intel.com>
<2414234.RRTHkAQoda@xps>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2414234.RRTHkAQoda@xps>
User-Agent: Mutt/1.11.4 (2019-03-13)
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v4] examples/l3fwd: fix
unaligned memory access
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Tue, Jul 30, 2019 at 10:50:14AM +0200, Thomas Monjalon wrote:
> Review please?
>
> 26/07/2019 15:58, hgovindh:
> > Fix unaligned memory access when reading IPv6 header which
> > leads to segmentation fault by changing aligned memory read
> > to unaligned memory read.
> >
> > Bugzilla ID: 279
> > Fixes: 64d3955de1de ("examples/l3fwd: fix ARM build")
> > Cc: maciej.czekaj@caviumnetworks.com
> > Cc: stable@dpdk.org
> > Signed-off-by: hgovindh <hariprasad.govindharajan@intel.com>
> > --- a/examples/l3fwd/l3fwd_em.c
> > +++ b/examples/l3fwd/l3fwd_em.c
> > +#if defined RTE_ARCH_X86
> > + key.xmm[1] = _mm_loadu_si128(data1);
> > +#else
> > key.xmm[1] = *(xmm_t *)data1;
> > -
> > +#endif
>
The blank line should be re-added below the #ifdef. Apart from that the fix
looks correct to me.
Reviewed-by: Bruce Richardson <bruce.richardson@intel.com>