From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BBBACA0613 for ; Tue, 30 Jul 2019 13:04:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9ABA01C0AB; Tue, 30 Jul 2019 13:04:25 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 4311E1C02E; Tue, 30 Jul 2019 13:04:24 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x6UB00Ng000496; Tue, 30 Jul 2019 04:04:23 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=pfpt0818; bh=3Vgo1+HZOfW7RDEGe4P/aOIbISekbBTbZqhnfbJ1P8c=; b=zPDSiOq06HkFt1mOb9oSU/eoAIv1960l3QmuwRBb/fJv2DPfIrULn/ocLm/sypW7pFfv 2/hzS9LrNcGwnpnKeFkr0HIp3heXZZtWkHNEEXzwknGTU7EFYb3lY17jfVYn5DyL+YOT N9smWLPQXxahwcD6Zx6k9oYryvHRIrmjbwnDIfZySs2a70LXINTGJt3GF18cv5vk6YYu 7f+RXl6WcH92SE7AsuoqjtoS35pabrCiRj0QTsE/FZrrmxd+vYI4njh+GpEatA5lfgzR ttjdEAjIpYWHAJwqMG2Qp2w+yTkdygteZY1l73ss/ro3N+TJQk61eKEoTc35k1+KqADC jA== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0a-0016f401.pphosted.com with ESMTP id 2u0kyq4fnx-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 30 Jul 2019 04:04:23 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 30 Jul 2019 04:04:22 -0700 Received: from maili.marvell.com (10.93.176.43) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server id 15.0.1367.3 via Frontend Transport; Tue, 30 Jul 2019 04:04:22 -0700 Received: from jerin-lab.marvell.com (jerin-lab.marvell.com [10.28.34.14]) by maili.marvell.com (Postfix) with ESMTP id 99A793F7040; Tue, 30 Jul 2019 04:04:19 -0700 (PDT) From: To: , Maxime Coquelin , Tiwei Bie , Zhihong Wang CC: , Jerin Jacob , Jianfeng Tan , Date: Tue, 30 Jul 2019 16:34:06 +0530 Message-ID: <20190730110406.30007-1-jerinj@marvell.com> X-Mailer: git-send-email 2.22.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-07-30_05:2019-07-29,2019-07-30 signatures=0 Subject: [dpdk-dev] [PATCH] net/virtio: fix build errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Jerin Jacob Add extern to variable declaration to avoid some compiler treating it as variable definition. build error log: lib/librte_pmd_virtio.a(vhost_kernel.o):(.rodata+0x110): multiple definition of `vhost_msg_strings' lib/librte_pmd_virtio.a(vhost_user.o):(.data.rel.ro.local+0x0): first defined here lib/librte_pmd_virtio.a(virtio_user_dev.o):(.rodata+0xe8): multiple definition of `vhost_msg_strings' lib/librte_pmd_virtio.a(vhost_user.o):(.data.rel.ro.local+0x0): first defined here Fixes: 33d24d65fe2b ("net/virtio-user: abstract backend operations") Cc: Jianfeng Tan Cc: stable@dpdk.org Signed-off-by: Jerin Jacob --- drivers/net/virtio/virtio_user/vhost.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtio_user/vhost.h b/drivers/net/virtio/virtio_user/vhost.h index 55f47036b..1e784e58e 100644 --- a/drivers/net/virtio/virtio_user/vhost.h +++ b/drivers/net/virtio/virtio_user/vhost.h @@ -67,7 +67,7 @@ enum vhost_user_request { VHOST_USER_MAX }; -const char * const vhost_msg_strings[VHOST_USER_MAX]; +extern const char * const vhost_msg_strings[VHOST_USER_MAX]; struct vhost_memory_region { uint64_t guest_phys_addr; -- 2.22.0