From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17350A0613 for ; Tue, 30 Jul 2019 14:21:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D0B411C10D; Tue, 30 Jul 2019 14:21:14 +0200 (CEST) Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 2D6131C069 for ; Tue, 30 Jul 2019 14:21:13 +0200 (CEST) Received: from cpe-2606-a000-111b-6140-0-0-0-162e.dyn6.twc.com ([2606:a000:111b:6140::162e] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1hsR7q-0006fH-43; Tue, 30 Jul 2019 08:21:10 -0400 Date: Tue, 30 Jul 2019 08:20:36 -0400 From: Neil Horman To: Thomas Monjalon Cc: dev@dpdk.org, Bruce Richardson , shreyansh.jain@nxp.com, hemant.agrawal@nxp.com, david.marchand@redhat.com Message-ID: <20190730122036.GA19075@hmswarspite.think-freely.org> References: <20190705093401.69913-1-bruce.richardson@intel.com> <2033098.zfnWnl858g@xps> <1605498.ZGlQ3oZTaz@xps> <3048859.hlssD6FjPI@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3048859.hlssD6FjPI@xps> User-Agent: Mutt/1.12.0 (2019-05-25) X-Spam-Score: -2.9 (--) X-Spam-Status: No Subject: Re: [dpdk-dev] [RFC PATCH 0/2] standardize rawdev names X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jul 30, 2019 at 10:17:46AM +0200, Thomas Monjalon wrote: > 05/07/2019 11:39, Thomas Monjalon: > > 05/07/2019 11:38, Thomas Monjalon: > > > 05/07/2019 11:35, Bruce Richardson: > > > > On Fri, Jul 05, 2019 at 10:33:59AM +0100, Bruce Richardson wrote: > > > > > The names of the rawdev drivers and the resultant libraries they built > > > > > were pretty inconsistent. In terms of directory names, some had "rawdev" > > > > > in the name, e.g. skeleton_rawdev, ifpga_rawdev, while others didn't. > > > > > Also, for the built .so/.a libraries, the names were not always > > > > > consistent between make and meson, as, while meson enforced a consistent > > > > > naming scheme, make did not, leading to differences - especially for > > > > > those drivers with "rawdev" in the directory name. > > > > > > > > > > This patchset attempts to make things more standardized by removing > > > > > "rawdev" from all directory names - the drivers are in the "drivers/raw" > > > > > directory after all - and then standardizing the library names to > > > > > "librte_rawdev_" for both make and meson. > > > > > > > > > > Bruce Richardson (2): drivers/raw: remove rawdev from driver directory > > > > > names drivers/raw: standardize name format of rawdev drivers > > > > > > > > > Since the .so/.a files we produce are changing, would this patchset - if > > > > accepted - need a deprecation notice in 19.08 for a future 19.11 merge? > > > > > > I would say we can merge it in 19.08 without prior notice. > > > Any other opinion? > > > > Cc Neil > > We got no more opinion. > Does it mean I can merge it in 19.08-rc3? > > > Sorry, I meant to get to this and completely forgot. I presume that this is solely a name change, and not a functional change, correct? I would think if thats the case, you could just release note the switch, and distributions could all linker files with the old names to maintain compatibility. Neil