From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B92D0A0613 for <public@inbox.dpdk.org>; Tue, 30 Jul 2019 17:34:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7D4751BF6E; Tue, 30 Jul 2019 17:34:03 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id E00BB1BF13 for <dev@dpdk.org>; Tue, 30 Jul 2019 17:34:01 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jul 2019 08:34:00 -0700 X-IronPort-AV: E=Sophos;i="5.64,327,1559545200"; d="scan'208";a="165879226" Received: from bricha3-mobl.ger.corp.intel.com ([10.251.80.128]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jul 2019 08:33:58 -0700 Date: Tue, 30 Jul 2019 16:33:55 +0100 From: Bruce Richardson <bruce.richardson@intel.com> To: Stephen Hemminger <stephen@networkplumber.org> Cc: Marcin Zapolski <marcinx.a.zapolski@intel.com>, dev@dpdk.org Message-ID: <20190730153355.GB1689@bricha3-MOBL.ger.corp.intel.com> References: <20190730124950.1293-1-marcinx.a.zapolski@intel.com> <20190730124950.1293-2-marcinx.a.zapolski@intel.com> <20190730082534.7f2138ee@hermes.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190730082534.7f2138ee@hermes.lan> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [RFC 19.11 1/2] ethdev: make DPDK core functions non-inline X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Tue, Jul 30, 2019 at 08:25:34AM -0700, Stephen Hemminger wrote: > On Tue, 30 Jul 2019 14:49:49 +0200 > Marcin Zapolski <marcinx.a.zapolski@intel.com> wrote: > > > Make rte_eth_rx_burst, rte_eth_tx_burst and other static inline ethdev > > functions not inline. They are referencing DPDK internal structures and > > inlining forces those structures to be exposed to user applications. > > > > In internal testing with i40e NICs a performance drop of about 2% was > > observed with testpmd. > > > > Signed-off-by: Marcin Zapolski <marcinx.a.zapolski@intel.com> > > Sorry 2% matters. Note that this is with testpmd. Are there many apps out there where a 2% drop in IO cost would be noticable?