DPDK patches and discussions
 help / color / mirror / Atom feed
From: Takeshi Yoshimura <tyos@jp.ibm.com>
To: dev@dpdk.org
Cc: Takeshi Yoshimura <tyos@jp.ibm.com>
Subject: [dpdk-dev] [PATCH] eal: forcing IOVA as PA in ppc
Date: Wed, 31 Jul 2019 12:35:23 +0900	[thread overview]
Message-ID: <20190731033523.2482-1-tyos@jp.ibm.com> (raw)

Commit b76fafb174d2 ("eal: fix IOVA mode selection as VA for PCI
drivers") breaks ppc apps with no IOVA configs (or RTE_IOVA_DC)
because of the inconsistency of user's request and the result of
device capability for IOVA mode. I updated the code to force IOVA as
PA in ppc as before because current ppc driver does not support VA
mode.

Theoretically, ppc can support VA mode, but I suspect that ppc with
VA mode may have performance issues to create a big DMA window
(VA often uses higher addresses than PA). So, I didn't change the
code to check device capability in ppc.

Signed-off-by: Takeshi Yoshimura <tyos@jp.ibm.com>
---
 lib/librte_eal/linux/eal/eal.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/eal.c
index 946222ccd..db2dec922 100644
--- a/lib/librte_eal/linux/eal/eal.c
+++ b/lib/librte_eal/linux/eal/eal.c
@@ -1121,6 +1121,12 @@ rte_eal_init(int argc, char **argv)
 				RTE_LOG(DEBUG, EAL, "KNI can not work since physical addresses are unavailable\n");
 			}
 		}
+#endif
+#ifdef RTE_ARCH_PPC_64
+		if (iova_mode == RTE_IOVA_VA) {
+			iova_mode = RTE_IOVA_PA;
+			RTE_LOG(WARNING, EAL, "Forcing IOVA as 'PA' because PPC uses PA mode.\n");
+		}
 #endif
 		rte_eal_get_configuration()->iova_mode = iova_mode;
 	} else {
-- 
2.17.1


             reply	other threads:[~2019-07-31  3:35 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-31  3:35 Takeshi Yoshimura [this message]
2019-07-31  9:10 ` Burakov, Anatoly
2019-07-31  9:29 ` David Marchand
2019-07-31 10:34 ` Takeshi T Yoshimura
2019-07-31 10:44 ` Takeshi T Yoshimura
2019-07-31 10:58   ` David Marchand
2019-07-31 19:23     ` David Christensen
2019-07-31 19:32       ` David Marchand
2019-07-31 21:20         ` David Christensen
2019-08-01  5:04           ` David Marchand
2019-07-31 19:44   ` David Marchand
2019-08-01  4:10   ` Takeshi T Yoshimura
2019-08-01  5:01     ` David Marchand
2019-08-01  5:25     ` Takeshi T Yoshimura
2019-08-01  7:15       ` David Marchand
2019-08-01  8:46       ` Takeshi T Yoshimura
2019-08-01  9:46         ` David Marchand
2019-08-02  8:09         ` Takeshi T Yoshimura
2019-08-02  8:22           ` David Marchand
2019-08-01  4:12   ` Takeshi T Yoshimura
2019-08-01 13:01 ` David Marchand
2019-08-02  8:50   ` Burakov, Anatoly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190731033523.2482-1-tyos@jp.ibm.com \
    --to=tyos@jp.ibm.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).