DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: kkanas@marvell.com, dev@dpdk.org,
	Jasvinder Singh <jasvinder.singh@intel.com>,
	Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Subject: Re: [dpdk-dev] [PATCH] mk: fix printing target name when build completes
Date: Wed, 31 Jul 2019 09:29:20 +0100	[thread overview]
Message-ID: <20190731082919.GA1705@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <2035006.yWZ2hScJmE@xps>

On Tue, Jul 30, 2019 at 11:35:52PM +0200, Thomas Monjalon wrote:
> 04/06/2019 11:21, kkanas@marvell.com:
> > --- a/config/defconfig_x86_64-native-linuxapp-gcc
> > +++ b/config/defconfig_x86_64-native-linuxapp-gcc
> > +CONFIG_RTE_EXEC_ENV="linux"
> 
> Why do you do this change in this file?
> 
> I think changing this variable can break backward compatibility.
> 
I think it will, which is why I did not change it back in the original set.
In terms of incorrect printouts, what actually needs to be done to fix this
is to record the original $T value requested when doing the "make config"
or "make install T=" command. For the make install case, we can just print
$T at the end, but for the case where "make config" and "make" are run
separately, some new value would need to be added to the .config file.

Regards,
/Bruce

  reply	other threads:[~2019-07-31  8:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-04  9:21 [dpdk-dev] [PATCH] eal: fix spelling kkanas
2019-06-04  9:21 ` [dpdk-dev] [PATCH] mk: fix printing target name when build completes kkanas
2019-07-30 21:35   ` Thomas Monjalon
2019-07-31  8:29     ` Bruce Richardson [this message]
2019-07-07 21:54 ` [dpdk-dev] [PATCH] eal: fix spelling Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190731082919.GA1705@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=jasvinder.singh@intel.com \
    --cc=kkanas@marvell.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).