From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3A07AA10DA for ; Wed, 31 Jul 2019 10:29:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E48521BFF7; Wed, 31 Jul 2019 10:29:27 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 324C21BFF5 for ; Wed, 31 Jul 2019 10:29:26 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jul 2019 01:29:25 -0700 X-IronPort-AV: E=Sophos;i="5.64,329,1559545200"; d="scan'208";a="177237606" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.61]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jul 2019 01:29:23 -0700 Date: Wed, 31 Jul 2019 09:29:20 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: kkanas@marvell.com, dev@dpdk.org, Jasvinder Singh , Cristian Dumitrescu Message-ID: <20190731082919.GA1705@bricha3-MOBL.ger.corp.intel.com> References: <20190604092127.25000-1-kkanas@marvell.com> <20190604092127.25000-2-kkanas@marvell.com> <2035006.yWZ2hScJmE@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2035006.yWZ2hScJmE@xps> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH] mk: fix printing target name when build completes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jul 30, 2019 at 11:35:52PM +0200, Thomas Monjalon wrote: > 04/06/2019 11:21, kkanas@marvell.com: > > --- a/config/defconfig_x86_64-native-linuxapp-gcc > > +++ b/config/defconfig_x86_64-native-linuxapp-gcc > > +CONFIG_RTE_EXEC_ENV="linux" > > Why do you do this change in this file? > > I think changing this variable can break backward compatibility. > I think it will, which is why I did not change it back in the original set. In terms of incorrect printouts, what actually needs to be done to fix this is to record the original $T value requested when doing the "make config" or "make install T=" command. For the make install case, we can just print $T at the end, but for the case where "make config" and "make" are run separately, some new value would need to be added to the .config file. Regards, /Bruce