From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 04C04A10DA for ; Wed, 31 Jul 2019 17:36:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2C0F71BFC1; Wed, 31 Jul 2019 17:36:15 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id C734E1BF1A for ; Wed, 31 Jul 2019 17:36:13 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jul 2019 08:36:12 -0700 X-IronPort-AV: E=Sophos;i="5.64,330,1559545200"; d="scan'208";a="371561393" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.61]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jul 2019 08:36:11 -0700 Date: Wed, 31 Jul 2019 16:36:08 +0100 From: Bruce Richardson To: Aaron Conole Cc: dev@dpdk.org, Michael Santana , David Marchand , Ferruh Yigit , Luca Boccassi Message-ID: <20190731153608.GG1705@bricha3-MOBL.ger.corp.intel.com> References: <20190731145030.19956-1-aconole@redhat.com> <20190731145030.19956-2-aconole@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190731145030.19956-2-aconole@redhat.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH 1/2] tests: Fix unit tests for shared builds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jul 31, 2019 at 10:50:29AM -0400, Aaron Conole wrote: > From: Michael Santana > > Currently many unit tests fail when running tests under shared builds. > This happens because of missing driver dependencies. This is fixed by > explicitly linking in missing drivers for the test application. > > before and after (clang): > https://travis-ci.com/Maickii/dpdk-2/jobs/212329160#L623 > https://travis-ci.com/Maickii/dpdk-2/jobs/212335912#L620 > > Suggested-by: Bruce Richardson > Suggested-by: David Marchand > Signed-off-by: Michael Santana > Signed-off-by: Aaron Conole > --- Rather than linking in the libraries explicitly, can you have the build do a "ninja install" at the end to place the libraries and drivers in their correct paths. That should mean that the test app (via eal) auto-loads all drivers from EAL_PMD_PATH (/usr/local/...). It would save having to make further changes to this file to link in any additional drivers. EAL_PMD_PATH is based off of $prefix for the build or install, so you can adjust that using meson options, if putting the drivers in /usr/local is not desirable for your test environments. /Bruce