From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93AA2A00E6 for ; Tue, 6 Aug 2019 13:49:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9233F1BE70; Tue, 6 Aug 2019 13:49:48 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id E71D71BE58 for ; Tue, 6 Aug 2019 13:49:46 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Aug 2019 04:49:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,353,1559545200"; d="scan'208";a="185628591" Received: from silpixa00381635.ir.intel.com (HELO silpixa00381635.ger.corp.intel.com) ([10.237.223.4]) by orsmga002.jf.intel.com with ESMTP; 06 Aug 2019 04:49:44 -0700 From: Jasvinder Singh To: dev@dpdk.org Cc: cristian.dumitrescu@intel.com Date: Tue, 6 Aug 2019 12:49:51 +0100 Message-Id: <20190806114951.62131-1-jasvinder.singh@intel.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190731113322.135053-1-jasvinder.singh@intel.com> References: <20190731113322.135053-1-jasvinder.singh@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix wrong value of tc ov weight X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The sched library checks the subport tc ov weight value regardless of whether RTE_SCHED_SUBPORT_TC_OV flag is enabled or not. This fix allows application to always set valid tc ov weight value. Fixes: 25961ff3bcb9 ("examples/ip_pipeline: add traffic manager object") error log SCHED: pipe_profile_check: Incorrect value for tc ov weight SCHED: rte_sched_port_check_params: Pipe profile check failed(-22) Command "tmgr" failed. Signed-off-by: Jasvinder Singh Acked-by: Cristian Dumitrescu --- v2: - add fix line - change title examples/ip_pipeline/cli.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c index f4c2be8b8..c6cf4204e 100644 --- a/examples/ip_pipeline/cli.c +++ b/examples/ip_pipeline/cli.c @@ -469,12 +469,10 @@ cmd_tmgr_pipe_profile(char **tokens, return; } -#ifdef RTE_SCHED_SUBPORT_TC_OV if (parser_read_uint8(&p.tc_ov_weight, tokens[19]) != 0) { snprintf(out, out_size, MSG_ARG_INVALID, "tc_ov_weight"); return; } -#endif for (i = 0; i < RTE_SCHED_BE_QUEUES_PER_PIPE; i++) if (parser_read_uint8(&p.wrr_weights[i], tokens[20 + i]) != 0) { -- 2.21.0