* [dpdk-dev] [PATCH] net/ixgbe: fix offset value check
@ 2019-08-07 6:43 Congwen Zhang
2019-08-07 8:33 ` Ye Xiaolong
0 siblings, 1 reply; 2+ messages in thread
From: Congwen Zhang @ 2019-08-07 6:43 UTC (permalink / raw)
To: wenzhuo.lu, konstantin.ananyev; +Cc: dev, Congwen Zhang
The "and" condition offset == 0 && offset == NVM_INVALID_PTR
can never be true.
Signed-off-by: Congwen Zhang <zhang.congwen@zte.com.cn>
---
drivers/net/ixgbe/base/ixgbe_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c
index fb50719..e2ffbe6 100644
--- a/drivers/net/ixgbe/base/ixgbe_common.c
+++ b/drivers/net/ixgbe/base/ixgbe_common.c
@@ -5040,7 +5040,7 @@ void ixgbe_get_oem_prod_version(struct ixgbe_hw *hw,
hw->eeprom.ops.read(hw, NVM_OEM_PROD_VER_PTR, &offset);
/* Return is offset to OEM Product Version block is invalid */
- if (offset == 0x0 && offset == NVM_INVALID_PTR)
+ if ((offset == 0x0) || (offset == NVM_INVALID_PTR))
return;
/* Read product version block */
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ixgbe: fix offset value check
2019-08-07 6:43 [dpdk-dev] [PATCH] net/ixgbe: fix offset value check Congwen Zhang
@ 2019-08-07 8:33 ` Ye Xiaolong
0 siblings, 0 replies; 2+ messages in thread
From: Ye Xiaolong @ 2019-08-07 8:33 UTC (permalink / raw)
To: Congwen Zhang; +Cc: wenzhuo.lu, konstantin.ananyev, dev
Hi,
On 08/07, Congwen Zhang wrote:
>The "and" condition offset == 0 && offset == NVM_INVALID_PTR
> can never be true.
A fix tag is missing here, you can refer to other fix commits in git log history.
and also cc stable@dpdk.org.
>
>Signed-off-by: Congwen Zhang <zhang.congwen@zte.com.cn>
>---
> drivers/net/ixgbe/base/ixgbe_common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c
>index fb50719..e2ffbe6 100644
>--- a/drivers/net/ixgbe/base/ixgbe_common.c
>+++ b/drivers/net/ixgbe/base/ixgbe_common.c
>@@ -5040,7 +5040,7 @@ void ixgbe_get_oem_prod_version(struct ixgbe_hw *hw,
> hw->eeprom.ops.read(hw, NVM_OEM_PROD_VER_PTR, &offset);
>
> /* Return is offset to OEM Product Version block is invalid */
>- if (offset == 0x0 && offset == NVM_INVALID_PTR)
>+ if ((offset == 0x0) || (offset == NVM_INVALID_PTR))
> return;
>
> /* Read product version block */
>--
>1.8.3.1
>
For the patch, you can add my ack in next version.
Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-07 8:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-07 6:43 [dpdk-dev] [PATCH] net/ixgbe: fix offset value check Congwen Zhang
2019-08-07 8:33 ` Ye Xiaolong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).