From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
To: dev <dev@dpdk.org>
Cc: Luca Boccassi <bluca@debian.org>,
Thomas Monjalon <thomas@monjalon.net>,
Frank Heimes <frank.heimes@canonical.com>,
Christian Ehrhardt <christian.ehrhardt@canonical.com>
Subject: [dpdk-dev] [PATCH 0/1] PPC64 buid error in 19.08
Date: Tue, 13 Aug 2019 13:28:42 +0200 [thread overview]
Message-ID: <20190813112843.27072-1-christian.ehrhardt@canonical.com> (raw)
A build of recent DPDK 19.08 on all Ubuntu architectures returned this on ppc64:
../drivers/net/mlx4/mlx4_rxtx.c: In function ‘mlx4_tx_burst’:
../drivers/net/mlx4/mlx4_rxtx.c:919:14: error: incompatible types when
initializing type ‘__vector __bool int’ {aka ‘__vector(4) __bool int’}
using type ‘int’
919 | bool tso = txq->priv->tso && (buf->ol_flags & PKT_TX_TCP_SEG);
| ^~~
../drivers/net/mlx4/mlx4_rxtx.c:938:7: error: used vector type where scalar
is required
938 | if (tso) {
| ^~~
Which reminds everyone of the sad caps-lock story [1] which happened on 18.08.
Back then the fix was [2] and a discussion around ppc64 support state
happened, given that it wasn't even build-tested before release.
We might have to have the same discussion again, but for now I provided
the fix for the build fail on mlx4 implemented the same way as it was
done on mlx5 [2].
[1]: https://mails.dpdk.org/archives/dev/2018-August/110472.html
[2]: https://git.dpdk.org/dpdk/commit/?id=725f5dd0bfb50192a2d2341d4cc69084c2c4e03d
Christian Ehrhardt (1):
net/mlx4: fix build on PPC64
drivers/net/mlx4/mlx4_utils.h | 10 ++++++++++
1 file changed, 10 insertions(+)
--
2.22.0
next reply other threads:[~2019-08-13 11:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 11:28 Christian Ehrhardt [this message]
2019-08-13 11:28 ` [dpdk-dev] [PATCH 1/1] net/mlx4: fix build on PPC64 Christian Ehrhardt
2019-08-13 23:49 ` David Christensen
2019-08-28 12:30 ` Christian Ehrhardt
2019-08-29 17:06 ` David Christensen
2019-09-01 13:52 ` Matan Azrad
2019-09-02 10:12 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190813112843.27072-1-christian.ehrhardt@canonical.com \
--to=christian.ehrhardt@canonical.com \
--cc=bluca@debian.org \
--cc=dev@dpdk.org \
--cc=frank.heimes@canonical.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).