DPDK patches and discussions
 help / color / mirror / Atom feed
From: Neil Horman <nhorman@tuxdriver.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, Aaron Conole <aconole@redhat.com>
Subject: Re: [dpdk-dev] [PATCH] buildtools: lighter experimental symbol check
Date: Tue, 13 Aug 2019 20:09:04 -0400	[thread overview]
Message-ID: <20190814000904.GA11098@localhost.localdomain> (raw)
In-Reply-To: <CAJFAV8xDZn+r1wyjM+9whAcGHwV6_OXW9EwmNKL1PihJq90oyg@mail.gmail.com>

On Tue, Aug 13, 2019 at 08:32:44AM +0200, David Marchand wrote:
> On Mon, Aug 12, 2019 at 10:14 PM Neil Horman <nhorman@tuxdriver.com> wrote:
> >
> > On Mon, Aug 12, 2019 at 09:02:28AM +0200, David Marchand wrote:
> > > Dumping every object file for every symbol is too heavy.
> > > Use a temporary storage.
> > >
> > > Before:
> > > $ rm -rf master && make defconfig O=master
> > > $ time make EXTRA_CFLAGS=-g O=master
> > > [...]
> > > real  2m24.063s
> > > user  1m16.985s
> > > sys   1m46.372s
> > >
> > > After:
> > > $ rm -rf master && make defconfig O=master
> > > $ time make EXTRA_CFLAGS=-g O=master
> > > [...]
> > > real  1m37.110s
> > > user  0m49.417s
> > > sys   0m51.803s
> > >
> > > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > > ---
> > >  buildtools/check-experimental-syms.sh | 15 ++++++++-------
> > >  1 file changed, 8 insertions(+), 7 deletions(-)
> > >
> > > diff --git a/buildtools/check-experimental-syms.sh b/buildtools/check-experimental-syms.sh
> > > index 0f6c62d..47a06fc 100755
> > > --- a/buildtools/check-experimental-syms.sh
> > > +++ b/buildtools/check-experimental-syms.sh
> > > @@ -18,14 +18,15 @@ then
> > >       exit 0
> > >  fi
> > >
> > > +DUMPFILE=$(mktemp -t dpdk.${0##*/}.XXX.objdump)
> > > +trap 'rm -f "$DUMPFILE"' EXIT
> 
> "If a sigspec is EXIT (0) the command arg is executed on exit from the shell."
> 
> > > +objdump -t $OBJFILE >$DUMPFILE
> > > +
> > When does this temporary file get deleted?
> 
> It should be enough?
> 
Yes, thank you, I missed that.

Acked-by: Neil Horman <nhorman@tuxdriver.com>

> -- 
> David Marchand
> 

  reply	other threads:[~2019-08-14  0:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-12  7:02 David Marchand
2019-08-12 20:13 ` Neil Horman
2019-08-13  6:32   ` David Marchand
2019-08-14  0:09     ` Neil Horman [this message]
2019-10-09  8:11       ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190814000904.GA11098@localhost.localdomain \
    --to=nhorman@tuxdriver.com \
    --cc=aconole@redhat.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).