From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0A96AA0471 for ; Wed, 14 Aug 2019 08:51:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 74AB51BDFD; Wed, 14 Aug 2019 08:51:02 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 8D8148F96; Wed, 14 Aug 2019 08:51:00 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Aug 2019 23:50:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,384,1559545200"; d="scan'208";a="181424013" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.5]) by orsmga006.jf.intel.com with ESMTP; 13 Aug 2019 23:50:58 -0700 Date: Wed, 14 Aug 2019 14:50:06 +0800 From: Ye Xiaolong To: Xiaoyun Li Cc: jingjing.wu@intel.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20190814065006.GA25496@intel.com> References: <20190814060725.43129-1-xiaoyun.li@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190814060725.43129-1-xiaoyun.li@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] examples/ntb: fix resource leaks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 08/14, Xiaoyun Li wrote: >Resource file was not freed or pointed-to in fseek/ftell. This patch >fixed this issue which is found by coverity scan. > >Coverity issue: 347277 >Fixes: 440af660ff83 ("examples/ntb: fix error handling") >Cc: stable@dpdk.org > >Signed-off-by: Xiaoyun Li >--- > examples/ntb/ntb_fwd.c | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/examples/ntb/ntb_fwd.c b/examples/ntb/ntb_fwd.c >index f8c970cdb..bf8a73547 100644 >--- a/examples/ntb/ntb_fwd.c >+++ b/examples/ntb/ntb_fwd.c >@@ -127,11 +127,13 @@ cmd_sendfile_parsed(void *parsed_result, > > if (fseek(file, 0, SEEK_END) < 0) { > printf("Fail to get file size.\n"); >+ fclose(file); > return; > } > size = ftell(file); > if (fseek(file, 0, SEEK_SET) < 0) { > printf("Fail to get file size.\n"); >+ fclose(file); > return; > } > >-- >2.17.1 > Reviewed-by: Xiaolong Ye