* [dpdk-dev] [PATCH] net/octeontx2: fix port Tx VLAN insertion
@ 2019-08-16 4:19 Nithin Dabilpuram
2019-09-13 14:40 ` Jerin Jacob
0 siblings, 1 reply; 3+ messages in thread
From: Nithin Dabilpuram @ 2019-08-16 4:19 UTC (permalink / raw)
To: Jerin Jacob, Nithin Dabilpuram, Kiran Kumar K; +Cc: dev
This patch fixes configuration for port Tx vlan insertion feature.
As per latest Tx KEX profile, pf_func should be at
KW[0](47:32) and not KW[1](63:48).
Fixes: 168c59cfe42b ("net/octeontx2: add flow MCAM utility functions")
Cc: kirankumark@marvell.com
Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
---
drivers/net/octeontx2/otx2_vlan.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/octeontx2/otx2_vlan.c b/drivers/net/octeontx2/otx2_vlan.c
index c01089b..2be7671 100644
--- a/drivers/net/octeontx2/otx2_vlan.c
+++ b/drivers/net/octeontx2/otx2_vlan.c
@@ -468,9 +468,9 @@ nix_vlan_handle_default_tx_entry(struct rte_eth_dev *eth_dev,
pf_func = (dev->pf_func & 0xff) << 8;
pf_func |= (dev->pf_func >> 8) & 0xff;
- /* PF Func extracted to KW1[63:48] */
- entry.kw[1] = (uint64_t)pf_func << 48;
- entry.kw_mask[1] = (BIT_ULL(16) - 1) << 48;
+ /* PF Func extracted to KW1[47:32] */
+ entry.kw[0] = (uint64_t)pf_func << 32;
+ entry.kw_mask[0] = (BIT_ULL(16) - 1) << 32;
nix_set_tx_vlan_action(&entry, type, vtag_index);
vlan->def_tx_mcam_ent = entry;
--
2.8.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/octeontx2: fix port Tx VLAN insertion
2019-08-16 4:19 [dpdk-dev] [PATCH] net/octeontx2: fix port Tx VLAN insertion Nithin Dabilpuram
@ 2019-09-13 14:40 ` Jerin Jacob
2019-09-23 8:00 ` Jerin Jacob
0 siblings, 1 reply; 3+ messages in thread
From: Jerin Jacob @ 2019-09-13 14:40 UTC (permalink / raw)
To: Nithin Dabilpuram; +Cc: Jerin Jacob, Kiran Kumar K, dev
On Fri, Aug 16, 2019 at 9:50 AM Nithin Dabilpuram
<ndabilpuram@marvell.com> wrote:
>
> This patch fixes configuration for port Tx vlan insertion feature.
> As per latest Tx KEX profile, pf_func should be at
> KW[0](47:32) and not KW[1](63:48).
>
> Fixes: 168c59cfe42b ("net/octeontx2: add flow MCAM utility functions")
> Cc: kirankumark@marvell.com
Cc: stable@dpdk.org
>
> Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
> ---
> drivers/net/octeontx2/otx2_vlan.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/octeontx2/otx2_vlan.c b/drivers/net/octeontx2/otx2_vlan.c
> index c01089b..2be7671 100644
> --- a/drivers/net/octeontx2/otx2_vlan.c
> +++ b/drivers/net/octeontx2/otx2_vlan.c
> @@ -468,9 +468,9 @@ nix_vlan_handle_default_tx_entry(struct rte_eth_dev *eth_dev,
> pf_func = (dev->pf_func & 0xff) << 8;
> pf_func |= (dev->pf_func >> 8) & 0xff;
>
> - /* PF Func extracted to KW1[63:48] */
> - entry.kw[1] = (uint64_t)pf_func << 48;
> - entry.kw_mask[1] = (BIT_ULL(16) - 1) << 48;
> + /* PF Func extracted to KW1[47:32] */
> + entry.kw[0] = (uint64_t)pf_func << 32;
> + entry.kw_mask[0] = (BIT_ULL(16) - 1) << 32;
>
> nix_set_tx_vlan_action(&entry, type, vtag_index);
> vlan->def_tx_mcam_ent = entry;
> --
> 2.8.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/octeontx2: fix port Tx VLAN insertion
2019-09-13 14:40 ` Jerin Jacob
@ 2019-09-23 8:00 ` Jerin Jacob
0 siblings, 0 replies; 3+ messages in thread
From: Jerin Jacob @ 2019-09-23 8:00 UTC (permalink / raw)
To: Nithin Dabilpuram; +Cc: Jerin Jacob, Kiran Kumar K, dev, Ferruh Yigit
On Fri, Sep 13, 2019 at 8:10 PM Jerin Jacob <jerinjacobk@gmail.com> wrote:
>
> On Fri, Aug 16, 2019 at 9:50 AM Nithin Dabilpuram
> <ndabilpuram@marvell.com> wrote:
> >
> > This patch fixes configuration for port Tx vlan insertion feature.
> > As per latest Tx KEX profile, pf_func should be at
> > KW[0](47:32) and not KW[1](63:48).
> >
> > Fixes: 168c59cfe42b ("net/octeontx2: add flow MCAM utility functions")
> > Cc: kirankumark@marvell.com
>
> Cc: stable@dpdk.org
>
> >
> > Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
>
> Acked-by: Jerin Jacob <jerinj@marvell.com>
Applied to dpdk-next-net-mrvl/master. Thanks
>
>
> > ---
> > drivers/net/octeontx2/otx2_vlan.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/octeontx2/otx2_vlan.c b/drivers/net/octeontx2/otx2_vlan.c
> > index c01089b..2be7671 100644
> > --- a/drivers/net/octeontx2/otx2_vlan.c
> > +++ b/drivers/net/octeontx2/otx2_vlan.c
> > @@ -468,9 +468,9 @@ nix_vlan_handle_default_tx_entry(struct rte_eth_dev *eth_dev,
> > pf_func = (dev->pf_func & 0xff) << 8;
> > pf_func |= (dev->pf_func >> 8) & 0xff;
> >
> > - /* PF Func extracted to KW1[63:48] */
> > - entry.kw[1] = (uint64_t)pf_func << 48;
> > - entry.kw_mask[1] = (BIT_ULL(16) - 1) << 48;
> > + /* PF Func extracted to KW1[47:32] */
> > + entry.kw[0] = (uint64_t)pf_func << 32;
> > + entry.kw_mask[0] = (BIT_ULL(16) - 1) << 32;
> >
> > nix_set_tx_vlan_action(&entry, type, vtag_index);
> > vlan->def_tx_mcam_ent = entry;
> > --
> > 2.8.4
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-23 8:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-16 4:19 [dpdk-dev] [PATCH] net/octeontx2: fix port Tx VLAN insertion Nithin Dabilpuram
2019-09-13 14:40 ` Jerin Jacob
2019-09-23 8:00 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).