From: Stephen Hemminger <stephen@networkplumber.org>
To: Jim Harris <james.r.harris@intel.com>
Cc: dev@dpdk.org, anatoly.burakov@intel.com
Subject: Re: [dpdk-dev] [PATCH v4] timer: don't check tsc flags in secondary processes
Date: Mon, 19 Aug 2019 10:10:02 -0700 [thread overview]
Message-ID: <20190819101002.1c250d01@hermes.lan> (raw)
In-Reply-To: <156620773023.46233.9134599999619749565.stgit@jrharri1-skx>
On Mon, 19 Aug 2019 02:42:10 -0700
Jim Harris <james.r.harris@intel.com> wrote:
> check_tsc_flags() parses /proc/cpuinfo and prints
> warning messages if any cores don't have constant_tsc
> and nonstop_tsc. It has no functional meaning.
> This consumes a noticeable amount of time in
> secondary processes - on my test system, it consumes
> 21ms out of the 66ms total execution time for
> rte_eal_init().
>
> So let's just skip checking these flags in secondary
> processes. Since the primary process is already
> parsing the entirety of /proc/cpuinfo, the warning
> printed in the primary process should be sufficient.
>
> Signed-off-by: Jim Harris <james.r.harris@intel.com>
Since all it does is print a warning, I would argue the code is useless
anyway and should just be removed. The warning doesn't provide any
indication of what to do for users; or even tell them what the effect is.
prev parent reply other threads:[~2019-08-19 17:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 9:42 Jim Harris
2019-08-19 17:10 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190819101002.1c250d01@hermes.lan \
--to=stephen@networkplumber.org \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=james.r.harris@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).