From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77AF9A046B for ; Wed, 21 Aug 2019 07:21:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D48F21BEDD; Wed, 21 Aug 2019 07:21:20 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 093A34C9D for ; Wed, 21 Aug 2019 07:21:18 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Aug 2019 22:21:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,411,1559545200"; d="scan'208";a="378826844" Received: from dpdk-virtio-tbie-2.sh.intel.com (HELO ___) ([10.67.104.71]) by fmsmga006.fm.intel.com with ESMTP; 20 Aug 2019 22:21:15 -0700 Date: Wed, 21 Aug 2019 13:19:00 +0800 From: Tiwei Bie To: Jim Harris Cc: dev@dpdk.org, maxime.coquelin@redhat.com, zhihong.wang@intel.com Message-ID: <20190821051900.GA19939@___> References: <156629384840.23278.17587309426304779602.stgit@jrharri1-skx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <156629384840.23278.17587309426304779602.stgit@jrharri1-skx> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] vhost: add __rte_experimental to rte_vhost_va_from_guest_pa X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Aug 20, 2019 at 02:37:28AM -0700, Jim Harris wrote: > This function is listed under EXPERIMENTAL in the > rte_vhost_version.map, so it needs to be marked > with __rte_experimental in the header file as well. > > Found by check-experimental-syms.sh when trying to compile > DPDK with -finstrument-functions. This script didn't > catch this in the normal case, since the function is > declared __rte_always_inline. > > Signed-off-by: Jim Harris > --- > lib/librte_vhost/rte_vhost.h | 1 + > 1 file changed, 1 insertion(+) Fixes: 41333fba5b98 ("vhost: introduce safe API for GPA translation") Cc: stable@dpdk.org Reviewed-by: Tiwei Bie Thanks, Tiwei > > diff --git a/lib/librte_vhost/rte_vhost.h b/lib/librte_vhost/rte_vhost.h > index 7fb172912..fc27bc21e 100644 > --- a/lib/librte_vhost/rte_vhost.h > +++ b/lib/librte_vhost/rte_vhost.h > @@ -225,6 +225,7 @@ rte_vhost_gpa_to_vva(struct rte_vhost_memory *mem, uint64_t gpa) > * @return > * the host virtual address on success, 0 on failure > */ > +__rte_experimental > static __rte_always_inline uint64_t > rte_vhost_va_from_guest_pa(struct rte_vhost_memory *mem, > uint64_t gpa, uint64_t *len) >