From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BCF1FA046B for ; Sat, 24 Aug 2019 20:20:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0E49D1BFDB; Sat, 24 Aug 2019 20:20:37 +0200 (CEST) Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by dpdk.org (Postfix) with ESMTP id 69A3B1BFD8 for ; Sat, 24 Aug 2019 20:20:35 +0200 (CEST) Received: by mail-io1-f65.google.com with SMTP id j4so19417158iog.11 for ; Sat, 24 Aug 2019 11:20:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mY+loyt8zm1zlxvcWG1bdW62yxSUBxivqf1icWpswfY=; b=i3n2uTbuKzToyAtVozqPHsVG4yT/hqaXFeX2Po+AbB9f+kH8S5nhoNuDcTLOoP+q01 wKDy5e1jUSj6EcbfqCSYtgES3HDLRhUqCWElbDnmaV70zN9580eM10VHcWfpnSylk+VH kcpMR2CN1/wqmSDqkIwqNndOfK2CB4/bfBPq/fyVJASYMtCTp1DtELUdlkkiMYwKy9MR lS1qT6W/FrLpgA2+fa9GzqnK24cLpWL1ZSCb1PUac8gOEqascPASANbXbwZADL6NsMEI UyYjnbP88tjLtmoIKjsIzLsuCwNk3qi7JlJolo3s64G0zftJjgYxH6pTpxhyZQ/BiLA1 UqsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mY+loyt8zm1zlxvcWG1bdW62yxSUBxivqf1icWpswfY=; b=U7QpaZVBZ5XlQ9e0+3n+omyy3rzzceyRgh9dmfrmytHxzKBdnXrYqTAC/CoKj0bCyq DXbwYdMyHVkw0P57jWjGerT36gD4WBc+IQ2bRjSSl+gL3WP7dZjAzr67xRp8mAjiWSig WkjxOKWDJ7u+CxuD3sy5ME4mPoHUtN+iqNv/ic5WDBSa9CNIdIkJYNyKjwV4CdVsEH7c n9fNK42nJx0ro73m7okHBxemskDGoSmJwHg6wJt2DCB2nbNxcAyfwI54GfpBgZHhEa/c /Bi6tL9KsQHoBb9N/2scOzAKj4OcMPZ+HaF+mYvtVHqxVrJIbf4cTtfZ17u5fLtCH8WC CXZg== X-Gm-Message-State: APjAAAV4mX5AAAg+Sqd/eLQaSdvDMgdPxByCMKEL6vI0zDmAW/z74VZy MC7Pih5avDbg0M0Qydl08/XmCPBuSv4= X-Google-Smtp-Source: APXvYqxL+9/grf6NfNDP3PPI+5my6yI5kxoRQmYodzyyyrhl13psIKQZ68odSOU9IcTnEc6FM61rbw== X-Received: by 2002:a05:6602:2413:: with SMTP id s19mr15075948ioa.161.1566670834777; Sat, 24 Aug 2019 11:20:34 -0700 (PDT) Received: from xps13.local.tld (cpe-67-255-90-149.maine.res.rr.com. [67.255.90.149]) by smtp.gmail.com with ESMTPSA id e19sm4775735iom.57.2019.08.24.11.20.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 24 Aug 2019 11:20:34 -0700 (PDT) Date: Thu, 22 Aug 2019 21:19:03 -0400 From: Stephen Hemminger To: Cc: , , John McNamara , Marko Kovacevic , Thomas Monjalon , Ferruh Yigit , Message-ID: <20190822211853.7bb98687@xps13> In-Reply-To: <20190821204755.1990-3-pbhagavatula@marvell.com> References: <20190821204755.1990-1-pbhagavatula@marvell.com> <20190821204755.1990-3-pbhagavatula@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 2/7] ethdev: add mbuf RSS update as an offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 22 Aug 2019 02:17:50 +0530 wrote: > From: Pavan Nikhilesh > > Add new Rx offload flag `DEV_RX_OFFLOAD_RSS_HASH` which can be used to > enable/disable PMDs write to `rte_mbuf::hash::rss`. > PMDs notify the validity of `rte_mbuf::hash:rss` to the applcation > by enabling `PKT_RX_RSS_HASH ` flag in `rte_mbuf::ol_flags`. > > Signed-off-by: Pavan Nikhilesh > Reviewed-by: Andrew Rybchenko Is this really a good idea? Every bit of hardware that works on Windows with RSS is required to supply the hash (for software steering). So if adding an additional capability, just adds another bit of complexity, code coverage, and one more thing that won't be tested by everyone. If hardware has it why not set it? Adding a branch is more expensive than an unused assignment.