From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 5640DA0613
for <public@inbox.dpdk.org>; Wed, 28 Aug 2019 16:46:59 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 9E88D1BFD7;
Wed, 28 Aug 2019 16:46:42 +0200 (CEST)
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
by dpdk.org (Postfix) with ESMTP id 429E21BEEE
for <dev@dpdk.org>; Wed, 28 Aug 2019 16:46:39 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D28CD1570;
Wed, 28 Aug 2019 07:46:38 -0700 (PDT)
Received: from qc2400f-1.austin.arm.com (qc2400f-1.austin.arm.com
[10.118.12.34])
by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C08ED3F246;
Wed, 28 Aug 2019 07:46:38 -0700 (PDT)
From: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
To: olivier.matz@6wind.com, yipeng1.wang@intel.com, sameh.gobriel@intel.com,
bruce.richardson@intel.com, pablo.de.lara.guarch@intel.com,
honnappa.nagarahalli@arm.com
Cc: dev@dpdk.org, dharmik.thakkar@arm.com, gavin.hu@arm.com,
ruifeng.wang@arm.com, nd@arm.com
Date: Wed, 28 Aug 2019 09:46:12 -0500
Message-Id: <20190828144614.25284-4-honnappa.nagarahalli@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20190828144614.25284-1-honnappa.nagarahalli@arm.com>
References: <20190828144614.25284-1-honnappa.nagarahalli@arm.com>
Subject: [dpdk-dev] [PATCH 3/5] tools/checkpatch: relax constraints on
__rte_experimental
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Relax the constraints on __rte_experimental usage, allow redefining
to macros.
Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Reviewed-by: Gavin Hu <gavin.hu@arm.com>
---
devtools/checkpatches.sh | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index 560e6ce93..090c9b08a 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -99,9 +99,14 @@ check_experimental_tags() { # <patch>
ret = 1;
}
if ($1 != "+__rte_experimental" || $2 != "") {
- print "__rte_experimental must appear alone on the line" \
- " immediately preceding the return type of a function."
- ret = 1;
+ # code such as "#define XYZ __rte_experimental" is
+ # allowed
+ if ($1 != "+#define") {
+ print "__rte_experimental must appear alone " \
+ "on the line immediately preceding the " \
+ "return type of a function."
+ ret = 1;
+ }
}
}
END {
--
2.17.1