From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD2ADA0613 for ; Thu, 29 Aug 2019 17:34:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 833351E542; Thu, 29 Aug 2019 17:34:39 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id E48AA1E53D for ; Thu, 29 Aug 2019 17:34:37 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Aug 2019 08:34:36 -0700 X-IronPort-AV: E=Sophos;i="5.64,443,1559545200"; d="scan'208";a="265022816" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.46]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Aug 2019 08:34:35 -0700 Date: Thu, 29 Aug 2019 16:34:32 +0100 From: Bruce Richardson To: Christian Ehrhardt Cc: dev , Kevin Laatz , Luca Boccassi , Thomas Monjalon Message-ID: <20190829153431.GA624@bricha3-MOBL.ger.corp.intel.com> References: <20190829153003.7974-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190829153003.7974-1-christian.ehrhardt@canonical.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH v2] build: avoid --as-needed as it causes overlinking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Aug 29, 2019 at 05:30:03PM +0200, Christian Ehrhardt wrote: > A while ago telemetry was added in 57ae0ec6 and it also added as-needed > to config/meson.build. This seems no more needed these days as due to other > build changes the ordering in buildlogs is: > [...] -lrte_telemetry [...] -Wl,--no-as-needed [...] > Which means telemetry no more benefits from --no-as-needed anyway. > > Overlinking problems get triggered by the meson generated pkgconfig which > will have: > [...] -Wl,--no-as-needed > This will overlink and in addition anything that follows > as it also doesn't wrap back to --as-needed. So if a projects includes > dpdk libs + it will also consider with --no-as-needed. > > Fixes: https://bugs.launchpad.net/ubuntu/+source/dpdk/+bug/1841759 > > Signed-off-by: Christian Ehrhardt > Acked-by: Luca Boccassi > --- > config/meson.build | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/config/meson.build b/config/meson.build > index 2bafea530..a27f731f8 100644 > --- a/config/meson.build > +++ b/config/meson.build > @@ -94,7 +94,6 @@ dpdk_conf.set('RTE_TOOLCHAIN_' + toolchain.to_upper(), 1) > dpdk_conf.set('RTE_ARCH_64', cc.sizeof('void *') == 8) > > add_project_link_arguments('-Wl,--no-as-needed', language: 'c') > -dpdk_extra_ldflags += '-Wl,--no-as-needed' > This seems strange to me. What is it about linking the dpdk apps that require the argument, but makes it safe for non-builtin apps to avoid having the arg?