From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B50E0A2E1B for ; Tue, 3 Sep 2019 07:05:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 344091D447; Tue, 3 Sep 2019 07:05:09 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id B71A81C1C0; Tue, 3 Sep 2019 07:05:06 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Sep 2019 22:05:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,461,1559545200"; d="scan'208";a="189705476" Received: from dpdk-virtio-tbie-2.sh.intel.com (HELO ___) ([10.67.104.71]) by FMSMGA003.fm.intel.com with ESMTP; 02 Sep 2019 22:05:04 -0700 Date: Tue, 3 Sep 2019 13:02:37 +0800 From: Tiwei Bie To: Maxime Coquelin Cc: zhihong.wang@intel.com, amorenoz@redhat.com, xiao.w.wang@intel.com, dev@dpdk.org, jfreimann@redhat.com, stable@dpdk.org Message-ID: <20190903050237.GA26808@___> References: <20190829080000.20806-1-maxime.coquelin@redhat.com> <20190829080000.20806-15-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190829080000.20806-15-maxime.coquelin@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH 14/15] net/virtio: add vDPA op to get notification area X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Aug 29, 2019 at 09:59:59AM +0200, Maxime Coquelin wrote: > This patch implements the vDPA .get_notify_area() > callback. > > Signed-off-by: Maxime Coquelin > --- > drivers/net/virtio/virtio_vdpa.c | 33 ++++++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/drivers/net/virtio/virtio_vdpa.c b/drivers/net/virtio/virtio_vdpa.c > index e0b2f99ba..e681f527a 100644 > --- a/drivers/net/virtio/virtio_vdpa.c > +++ b/drivers/net/virtio/virtio_vdpa.c > @@ -707,6 +707,38 @@ virtio_vdpa_get_vfio_device_fd(int vid) > return list->dev->vfio_dev_fd; > } > > +static int > +virtio_vdpa_get_notify_area(int vid, int qid, uint64_t *offset, uint64_t *size) > +{ > + int did; > + struct internal_list *list; > + struct virtio_vdpa_device *dev; > + struct vfio_region_info reg = { .argsz = sizeof(reg) }; > + int ret; > + > + did = rte_vhost_get_vdpa_device_id(vid); > + list = find_internal_resource_by_did(did); > + if (list == NULL) { > + DRV_LOG(ERR, "Invalid device id: %d", did); > + return -1; > + } > + > + dev = list->dev; > + > + reg.index = dev->hw.notify_region; > + ret = ioctl(dev->vfio_dev_fd, VFIO_DEVICE_GET_REGION_INFO, ®); > + if (ret) { > + DRV_LOG(ERR, "Get not get device region info: %s", > + strerror(errno)); > + return -1; > + } > + > + *offset = dev->vqs[qid].notify_addr - dev->hw.notify_base + reg.offset; > + *size = 0x1000; It would be better to check whether the size is no less than 0x1000, otherwise it's possible to give guest the access to other registers of the vdpa device. Regards, Tiwei > + > + return 0; > +} > + > static struct rte_vdpa_dev_ops virtio_vdpa_ops = { > .get_queue_num = virtio_vdpa_get_queue_num, > .get_features = virtio_vdpa_get_features, > @@ -716,6 +748,7 @@ static struct rte_vdpa_dev_ops virtio_vdpa_ops = { > .set_features = virtio_vdpa_set_features, > .get_vfio_group_fd = virtio_vdpa_get_vfio_group_fd, > .get_vfio_device_fd = virtio_vdpa_get_vfio_device_fd, > + .get_notify_area = virtio_vdpa_get_notify_area, > }; > > static inline int > -- > 2.21.0 >