From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 5342AA2E1B
	for <public@inbox.dpdk.org>; Tue,  3 Sep 2019 08:25:03 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 05BCD1E551;
	Tue,  3 Sep 2019 08:25:02 +0200 (CEST)
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id B869B1E545
 for <dev@dpdk.org>; Tue,  3 Sep 2019 08:25:00 +0200 (CEST)
X-Amp-Result: UNSCANNABLE
X-Amp-File-Uploaded: False
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 02 Sep 2019 23:24:59 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,462,1559545200"; d="scan'208";a="189719141"
Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.5])
 by FMSMGA003.fm.intel.com with ESMTP; 02 Sep 2019 23:24:58 -0700
Date: Tue, 3 Sep 2019 14:23:06 +0800
From: Ye Xiaolong <xiaolong.ye@intel.com>
To: "Pei, Andy" <andy.pei@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Zhang, Qi Z" <qi.z.zhang@intel.com>,
 "Yigit, Ferruh" <ferruh.yigit@intel.com>, "Xu, Rosen" <rosen.xu@intel.com>
Message-ID: <20190903062306.GF4325@intel.com>
References: <1565280090-344032-1-git-send-email-andy.pei@intel.com>
 <1567392847-445709-1-git-send-email-andy.pei@intel.com>
 <20190902092341.GD1665@intel.com>
 <5941F446C088714A85408FA3132CFCBB0106BF60@SHSMSX105.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5941F446C088714A85408FA3132CFCBB0106BF60@SHSMSX105.ccr.corp.intel.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Subject: Re: [dpdk-dev] [PATCH v3] net/ipn3ke: setup MTU when HW init
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 09/03, Pei, Andy wrote:
[snip]
>	tmp = RTE_MAX(tmp, RTE_ETHER_MIN_MTU);
>
>>+	if (tmp > IPN3KE_MAC_FRAME_SIZE_MAX - IPN3KE_ETH_OVERHEAD)
>>+		tmp = IPN3KE_MAC_FRAME_SIZE_MAX - IPN3KE_ETH_OVERHEAD;
>
>	tmp = RTE_MIN(tmp, IPN3KE_MAC_FRAME_SIZE_MAX - IPN3KE_ETH_OVERHEAD);
>	
>in the definition of TRE_MIN and TRE_MAX, typeof() is used.
>RTE_ETHER_MIN_MTU is MACRO, your expression cause complie issue.
>

How about RTE_MAX(tmp, (uint32_t)RTE_ETHER_MIN_MTU)

Thanks,
Xiaolong