From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DAA3CA2E1B for ; Tue, 3 Sep 2019 17:03:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 59BDC1E56F; Tue, 3 Sep 2019 17:03:32 +0200 (CEST) Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id 279A31BEA0 for ; Tue, 3 Sep 2019 17:03:31 +0200 (CEST) Received: by mail-pf1-f193.google.com with SMTP id y9so10960782pfl.4 for ; Tue, 03 Sep 2019 08:03:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1MMksOiDp0qB0xKT2hpIS1iuUPLBLDrKgpdEu0DOhAs=; b=aFnGNEVPkxLUdRiFdlZnApr/nh3Taw8FEi7p920pddh4q5MxU/dhY7Lq0O1dCKvgIz 19jZcnuCSUBCLvxPxVbqxdA7+/CBx6P4WXF8clQGmc3Yr24ch5DoSMFKAuWWZlZbWEyA 5z82YjdJlhFTuo4dhDYlN+3RSeKRnGIiQrAvfikvi4c4RIlKHt4sYJLP/TwQMTzS6FIW x8Q7Nwun279lOYMRUuv2SYpweb3txHgLhymy8WIcgwqWPNrl4DL+VEVjhBYsb31TZ6i4 j4z8h+/dKenSO8rSn6+fk+caAlEjyorINNR1iJinGqpOERahMpORTx2B0FzVwxZtudMx Yl+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1MMksOiDp0qB0xKT2hpIS1iuUPLBLDrKgpdEu0DOhAs=; b=iwYIxc4GXxdAI3yAGlCXroFva9laY0frM5eN8FI3z4Vz17MYBECte2P5WWzgoE5HB3 wbCLIGXD/wuzZL4XXTsBNe/QknzQwpF6Up3nk1Pw/j1lhdQznZ/YbuQ2YXICuL4TTomx NHkl9eQTR0jIe6+QVKUZhRzrEiocuLcGWNgpczj6YDkpmitGP7A+7gc5CxzSeWkCnHAe ec5vwulH+rL0XM0lIvOfBjlF92cwIeM3U0AhPiovclmPYW+iKT1Gsknc+wXkDaeN8Dbj dwza5ssiXPPObJj6hNqfmbhSFELYUcgMjx6MWSePpHIzuFHAQ+Vvn+ltpW1Hze2gfdFZ PuXQ== X-Gm-Message-State: APjAAAW8qnRE73NkFGhbafdI1TpxYj+JfEC40DjB4i0DzwgZxZdQ4H1B VMGAd3N0it+gmoiC2HWmgJFk0Q== X-Google-Smtp-Source: APXvYqwMMRjb8sqrO8hfevjH/XBFjMKNRjKHJpDlwVRmmYeaVtbhG82WnVe3G45GafZYo0ZT74aCmQ== X-Received: by 2002:a63:ed50:: with SMTP id m16mr30383633pgk.209.1567523010028; Tue, 03 Sep 2019 08:03:30 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id h70sm17057741pgc.36.2019.09.03.08.03.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Sep 2019 08:03:29 -0700 (PDT) Date: Tue, 3 Sep 2019 08:03:25 -0700 From: Stephen Hemminger To: David Marchand Cc: Ferruh Yigit , dev , "John W. Linville" , Xiaolong Ye , Qi Zhang , Igor Russkikh , Pavel Belous , Allain Legacy , Matt Peters , Ravi Kumar , Rasesh Mody , Shahed Shaikh , Ajit Khaparde , Somnath Kotur , Chas Williams , Hemant Agrawal , Sachin Saxena , Wenzhuo Lu , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Gagandeep Singh , John Daley , Hyong Youb Kim , Gaetan Rivet , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Beilei Xing , Jingjing Wu , Qiming Yang , Rosen Xu , Konstantin Ananyev , Shijith Thotton , Srisivasubramanian Srinivasan , Jakub Grajciar , Matan Azrad , Shahaf Shuler , Yongseok Koh , Viacheslav Ovsiienko , Zyta Szpak , Liron Himi , Tomasz Duszynski , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Alejandro Lucero , Tetsuya Mukawa , Jerin Jacob , Bruce Richardson , Jasvinder Singh , Cristian Dumitrescu , Jan Remes , Rastislav Cernay , Keith Wiles , Maciej Czekaj , Maxime Coquelin , Tiwei Bie , Zhihong Wang , Yong Wang Message-ID: <20190903080325.779f972c@hermes.lan> In-Reply-To: References: <1566214919-32250-1-git-send-email-david.marchand@redhat.com> <1566214919-32250-11-git-send-email-david.marchand@redhat.com> <7eea5375-25e7-47c8-a522-e74b7267836c@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 10/11] drivers/net: use new logtype wrapper X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 3 Sep 2019 10:06:30 +0200 David Marchand wrote: > On Mon, Sep 2, 2019 at 6:11 PM Ferruh Yigit wrot= e: > > > > On 8/19/2019 12:41 PM, David Marchand wrote: =20 > > > Make use of the newly introduced wrapper. > > > > > > Signed-off-by: David Marchand =20 > > > > <...> > > =20 > > > diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c > > > index 931e4f4..c71b68e 100644 > > > --- a/drivers/net/mlx4/mlx4.c > > > +++ b/drivers/net/mlx4/mlx4.c > > > @@ -1274,16 +1274,14 @@ glue_error: > > > > > > #endif > > > > > > +RTE_LOG_REGISTER(mlx4_logtype, "pmd.net.mlx4", > > > + RTE_LOG_NOTICE, RTE_LOGTYPE_PMD); > > > + =20 > > > > btw, compiler is complaining about the ';' for mlx4/5 because of the pe= dantic > > parameter: > > > > error: ISO C does not allow extra =E2=80=98;=E2=80=99 outside of a func= tion [-Werror=3Dpedantic] > > =20 >=20 > Oops, I thought I had fixed it before sending the series.. thanks. Yeas, please remove ; after all RTE_LOG_REGISTER macro usage.