From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A0105A2E8D for ; Thu, 5 Sep 2019 17:26:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F29181EF66; Thu, 5 Sep 2019 17:26:51 +0200 (CEST) Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by dpdk.org (Postfix) with ESMTP id 61D7C1EDE1 for ; Thu, 5 Sep 2019 17:26:51 +0200 (CEST) Received: by mail-pl1-f195.google.com with SMTP id b10so1471798plr.4 for ; Thu, 05 Sep 2019 08:26:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LGRohCF2zF6E0kFKO1f2t9yasKQXg2/emVMy4a45bNk=; b=BtGcF6Heo0f/uFJ/e3VrkQTreusyUSsCkAXWAAyMDqfW2UxsxobM8yE5cr9hG6gyPk OhZ6ONHvvL/TXKxOGmG+JTMqUI0MHSiDIOrvqEK1Dvk21EwndFN9O9o1nrKyRNOpIen+ qj1kYnsMEXG6WAzsuwdrvqd1QQz7ygsDIIXs1RuQn/HUgZI5DsqCLtVM0tlSlmEz/xLx G4SS9Apszf4rPwSAfTzBknp0ZAlsQk5bUrb53Nyub+1WR07bswtOL8bZfBEjsTYEuUtv 8BwQvZXeEdgJtuaXjdn1rG+KefZU1kTiSNU5js+uTqu2xDCWibnvAMrc5uLBD9oMmNA6 hmLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LGRohCF2zF6E0kFKO1f2t9yasKQXg2/emVMy4a45bNk=; b=nZQBYeb0dJXoORmmPSlKpbodQaWB2LMv91+AEX8opTw/VuSwH0wqA2yJOHWodWoXpr XnHCQ7hri5jylK+Q17jAF4LI7ohHq1wutEid+xC+cQVzoo5UTDTq0HdXv/KC1P+ScKK2 PkaJ3UOQ4GS+0akD4roFux0CvMtPI6gqTS5XjEZDV87yd4bIoVBvP/6ljM999AxRfdCu gpqacL17WVRHJSCLN80SSX4eEW7vza0/C8i9tuvZBQ++O9GQnMrn+hxOfVB7WRfU9gHG bNnE99oo0oDHISjaMAV687wifd3HF5SXa8gdPt51p1zLEdcoId3Lw9rAG7ICFkO7S7Cv Zv8Q== X-Gm-Message-State: APjAAAUwJ6RSNbkzMuo5Cj1Uc+xNPDKhxRQuwObhgZQyGJMRZUCNHRY6 laZzaBHbOWtex+4ocUG+FDAg4w== X-Google-Smtp-Source: APXvYqx3NfwwA9ztsr5qPFz8EdkdowNl8n2Asho2JXuj5Kk3A+OKgilzoMA4hjPzENQwsYQXnsO2NQ== X-Received: by 2002:a17:902:7b94:: with SMTP id w20mr3922209pll.227.1567697210268; Thu, 05 Sep 2019 08:26:50 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id p11sm3320469pff.136.2019.09.05.08.26.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Sep 2019 08:26:49 -0700 (PDT) Date: Thu, 5 Sep 2019 08:26:47 -0700 From: Stephen Hemminger To: Dharmik Thakkar Cc: Wenzhuo Lu , Konstantin Ananyev , dev@dpdk.org, honnappa.nagarahalli@arm.com, ruifeng.wang@arm.com Message-ID: <20190905082647.63966b21@hermes.lan> In-Reply-To: <20190901065810.15137-2-dharmik.thakkar@arm.com> References: <20190901065810.15137-1-dharmik.thakkar@arm.com> <20190901065810.15137-2-dharmik.thakkar@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC 1/3] net/ixgbe: avoid multpile definitions of 'bool' X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, 1 Sep 2019 06:58:08 +0000 Dharmik Thakkar wrote: > Compilation issue arises due to multiple definitions of 'bool' > in 'ixgbe_ethdev.h'. > (Please note that this issue showed up when 'rte_rcu_qsbr.h' got included > within 'rte_hash.h', because 'rte_rcu_qsbr.h' includes 'stdbool.h'. This > is a temporary fix. Recommend suggesting better solution.) > > Signed-off-by: Dharmik Thakkar > --- > drivers/net/ixgbe/ixgbe_ethdev.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.h b/drivers/net/ixgbe/ixgbe_ethdev.h > index 6e9ed2e10f3c..dd4d6c022545 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.h > +++ b/drivers/net/ixgbe/ixgbe_ethdev.h > @@ -18,6 +18,7 @@ > #include > #include > #include > +#undef bool > #include > #include > #include Just fix ixgbe_ethdev.h to include stdbool itself? diff --git a/drivers/net/ixgbe/ixgbe_ethdev.h b/drivers/net/ixgbe/ixgbe_ethdev.h index 6e9ed2e10f3c..cf32b1761acb 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.h +++ b/drivers/net/ixgbe/ixgbe_ethdev.h @@ -6,6 +6,7 @@ #define _IXGBE_ETHDEV_H_ #include +#include #include "base/ixgbe_type.h" #include "base/ixgbe_dcb.h"