From: Andrzej Ostruszka <amo@semihalf.com>
To: dev@dpdk.org
Cc: Andrzej Ostruszka <aostruszka@marvell.com>
Subject: [dpdk-dev] [PATCH 09/10] net/ifc: fix maybe-uninitialized warnings for LTO build
Date: Thu, 5 Sep 2019 11:32:38 +0200 [thread overview]
Message-ID: <20190905093239.27187-10-amo@semihalf.com> (raw)
In-Reply-To: <20190905093239.27187-1-amo@semihalf.com>
During LTO build compiler reports some 'false positive' warnings about
variables being possibly used uninitialized. This patch silences these
warnings.
Signed-off-by: Andrzej Ostruszka <aostruszka@marvell.com>
---
drivers/net/ifc/ifcvf_vdpa.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ifc/ifcvf_vdpa.c b/drivers/net/ifc/ifcvf_vdpa.c
index 8de9ef199..4cdff8712 100644
--- a/drivers/net/ifc/ifcvf_vdpa.c
+++ b/drivers/net/ifc/ifcvf_vdpa.c
@@ -304,8 +304,8 @@ vdpa_ifcvf_stop(struct ifcvf_internal *internal)
struct ifcvf_hw *hw = &internal->hw;
uint32_t i;
int vid;
- uint64_t features;
- uint64_t log_base, log_size;
+ uint64_t features = 0;
+ uint64_t log_base = 0, log_size = 0;
uint64_t len;
vid = internal->vid;
@@ -348,6 +348,8 @@ vdpa_enable_vfio_intr(struct ifcvf_internal *internal, bool m_rx)
struct rte_vhost_vring vring;
int fd;
+ vring.callfd = -1;
+
nr_vring = rte_vhost_get_vring_num(internal->vid);
irq_set = (struct vfio_irq_set *)irq_set_buf;
@@ -442,6 +444,7 @@ notify_relay(void *arg)
}
internal->epfd = epfd;
+ vring.kickfd = -1;
for (qid = 0; qid < q_num; qid++) {
ev.events = EPOLLIN | EPOLLPRI;
rte_vhost_get_vhost_vring(internal->vid, qid, &vring);
@@ -577,7 +580,7 @@ m_ifcvf_start(struct ifcvf_internal *internal)
struct ifcvf_hw *hw = &internal->hw;
uint32_t i, nr_vring;
int vid, ret;
- struct rte_vhost_vring vq;
+ struct rte_vhost_vring vq = { 0 };
void *vring_buf;
uint64_t m_vring_iova = IFCVF_MEDIATED_VRING;
uint64_t size;
@@ -721,6 +724,7 @@ vring_relay(void *arg)
}
internal->epfd = epfd;
+ vring.kickfd = -1;
for (qid = 0; qid < q_num; qid++) {
ev.events = EPOLLIN | EPOLLPRI;
rte_vhost_get_vhost_vring(vid, qid, &vring);
@@ -930,11 +934,11 @@ ifcvf_dev_close(int vid)
static int
ifcvf_set_features(int vid)
{
- uint64_t features;
+ uint64_t features = 0;
int did;
struct internal_list *list;
struct ifcvf_internal *internal;
- uint64_t log_base, log_size;
+ uint64_t log_base = 0, log_size = 0;
did = rte_vhost_get_vdpa_device_id(vid);
list = find_internal_resource_by_did(did);
--
2.17.1
next prev parent reply other threads:[~2019-09-05 9:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 9:32 [dpdk-dev] [PATCH 00/10] Add an option to use LTO for DPDK build Andrzej Ostruszka
2019-09-05 9:32 ` [dpdk-dev] [PATCH 01/10] build: add an option to enable LTO build Andrzej Ostruszka
2019-09-05 9:36 ` Bruce Richardson
2019-09-05 9:43 ` Andrzej Ostruszka
2019-09-05 9:51 ` Bruce Richardson
2019-09-05 9:32 ` [dpdk-dev] [PATCH 02/10] eventdev: fix possible use of uninitialized var Andrzej Ostruszka
2019-09-05 9:32 ` [dpdk-dev] [PATCH 03/10] app/eventdev: fix maybe-uninitialized warnings for LTO build Andrzej Ostruszka
2019-09-05 9:32 ` [dpdk-dev] [PATCH 04/10] event/octeontx2: " Andrzej Ostruszka
2019-09-05 9:32 ` [dpdk-dev] [PATCH 05/10] app/test: " Andrzej Ostruszka
2019-09-05 13:25 ` Chas Williams
2019-09-17 10:41 ` Andrzej Ostruszka
2019-09-05 9:32 ` [dpdk-dev] [PATCH 06/10] net/dpaa2: fix possible use of uninitialized vars Andrzej Ostruszka
2019-09-05 9:32 ` [dpdk-dev] [PATCH 07/10] net/e1000: fix maybe-uninitialized warnings for LTO build Andrzej Ostruszka
2019-09-05 9:32 ` [dpdk-dev] [PATCH 08/10] net/i40e: " Andrzej Ostruszka
2019-09-05 9:32 ` Andrzej Ostruszka [this message]
2019-09-05 9:32 ` [dpdk-dev] [PATCH 10/10] net/qede: " Andrzej Ostruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190905093239.27187-10-amo@semihalf.com \
--to=amo@semihalf.com \
--cc=aostruszka@marvell.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).