From: Andrzej Ostruszka <amo@semihalf.com>
To: dev@dpdk.org
Cc: Andrzej Ostruszka <aostruszka@marvell.com>
Subject: [dpdk-dev] [PATCH 02/10] eventdev: fix possible use of uninitialized var
Date: Thu, 5 Sep 2019 11:32:31 +0200 [thread overview]
Message-ID: <20190905093239.27187-3-amo@semihalf.com> (raw)
In-Reply-To: <20190905093239.27187-1-amo@semihalf.com>
Fix the logic for the case of event queue allowing all schedule types.
Signed-off-by: Andrzej Ostruszka <aostruszka@marvell.com>
---
lib/librte_eventdev/rte_event_timer_adapter.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/librte_eventdev/rte_event_timer_adapter.c b/lib/librte_eventdev/rte_event_timer_adapter.c
index 5ce399eca..161e21a68 100644
--- a/lib/librte_eventdev/rte_event_timer_adapter.c
+++ b/lib/librte_eventdev/rte_event_timer_adapter.c
@@ -706,11 +706,11 @@ check_destination_event_queue(struct rte_event_timer *evtim,
RTE_EVENT_QUEUE_ATTR_SCHEDULE_TYPE,
&sched_type);
- if ((ret < 0 && ret != -EOVERFLOW) ||
- evtim->ev.sched_type != sched_type)
- return -1;
+ if ((ret == 0 && evtim->ev.sched_type == sched_type) ||
+ ret == -EOVERFLOW)
+ return 0;
- return 0;
+ return -1;
}
static int
--
2.17.1
next prev parent reply other threads:[~2019-09-05 9:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 9:32 [dpdk-dev] [PATCH 00/10] Add an option to use LTO for DPDK build Andrzej Ostruszka
2019-09-05 9:32 ` [dpdk-dev] [PATCH 01/10] build: add an option to enable LTO build Andrzej Ostruszka
2019-09-05 9:36 ` Bruce Richardson
2019-09-05 9:43 ` Andrzej Ostruszka
2019-09-05 9:51 ` Bruce Richardson
2019-09-05 9:32 ` Andrzej Ostruszka [this message]
2019-09-05 9:32 ` [dpdk-dev] [PATCH 03/10] app/eventdev: fix maybe-uninitialized warnings for " Andrzej Ostruszka
2019-09-05 9:32 ` [dpdk-dev] [PATCH 04/10] event/octeontx2: " Andrzej Ostruszka
2019-09-05 9:32 ` [dpdk-dev] [PATCH 05/10] app/test: " Andrzej Ostruszka
2019-09-05 13:25 ` Chas Williams
2019-09-17 10:41 ` Andrzej Ostruszka
2019-09-05 9:32 ` [dpdk-dev] [PATCH 06/10] net/dpaa2: fix possible use of uninitialized vars Andrzej Ostruszka
2019-09-05 9:32 ` [dpdk-dev] [PATCH 07/10] net/e1000: fix maybe-uninitialized warnings for LTO build Andrzej Ostruszka
2019-09-05 9:32 ` [dpdk-dev] [PATCH 08/10] net/i40e: " Andrzej Ostruszka
2019-09-05 9:32 ` [dpdk-dev] [PATCH 09/10] net/ifc: " Andrzej Ostruszka
2019-09-05 9:32 ` [dpdk-dev] [PATCH 10/10] net/qede: " Andrzej Ostruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190905093239.27187-3-amo@semihalf.com \
--to=amo@semihalf.com \
--cc=aostruszka@marvell.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).