From: Andrzej Ostruszka <amo@semihalf.com>
To: dev@dpdk.org
Cc: Andrzej Ostruszka <aostruszka@marvell.com>
Subject: [dpdk-dev] [PATCH 06/10] net/dpaa2: fix possible use of uninitialized vars
Date: Thu, 5 Sep 2019 11:32:35 +0200 [thread overview]
Message-ID: <20190905093239.27187-7-amo@semihalf.com> (raw)
In-Reply-To: <20190905093239.27187-1-amo@semihalf.com>
This patch fixes 'maybe-uninitialized' warnings reported by compiler
when using LTO.
Signed-off-by: Andrzej Ostruszka <aostruszka@marvell.com>
---
drivers/net/dpaa2/base/dpaa2_hw_dpni.c | 1 +
drivers/net/dpaa2/mc/dpkg.c | 2 +-
drivers/net/dpaa2/mc/dpni.c | 9 ++++++---
3 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/net/dpaa2/base/dpaa2_hw_dpni.c b/drivers/net/dpaa2/base/dpaa2_hw_dpni.c
index 56e2e56a3..2f6534a31 100644
--- a/drivers/net/dpaa2/base/dpaa2_hw_dpni.c
+++ b/drivers/net/dpaa2/base/dpaa2_hw_dpni.c
@@ -51,6 +51,7 @@ rte_pmd_dpaa2_set_custom_hash(uint16_t port_id,
kg_cfg.extracts[0].type = DPKG_EXTRACT_FROM_DATA;
kg_cfg.extracts[0].extract.from_data.offset = offset;
kg_cfg.extracts[0].extract.from_data.size = size;
+ kg_cfg.extracts[0].num_of_byte_masks = 0;
kg_cfg.num_extracts = 1;
ret = dpkg_prepare_key_cfg(&kg_cfg, p_params);
diff --git a/drivers/net/dpaa2/mc/dpkg.c b/drivers/net/dpaa2/mc/dpkg.c
index 80f94f40e..7aa63ea12 100644
--- a/drivers/net/dpaa2/mc/dpkg.c
+++ b/drivers/net/dpaa2/mc/dpkg.c
@@ -63,7 +63,7 @@ dpkg_prepare_key_cfg(const struct dpkg_profile_cfg *cfg, uint8_t *key_cfg_buf)
dpkg_set_field(extr->extract_type, EXTRACT_TYPE,
cfg->extracts[i].type);
- for (j = 0; j < DPKG_NUM_OF_MASKS; j++) {
+ for (j = 0; j < extr->num_of_byte_masks; j++) {
extr->masks[j].mask = cfg->extracts[i].masks[j].mask;
extr->masks[j].offset =
cfg->extracts[i].masks[j].offset;
diff --git a/drivers/net/dpaa2/mc/dpni.c b/drivers/net/dpaa2/mc/dpni.c
index 362cd476f..b74a1a317 100644
--- a/drivers/net/dpaa2/mc/dpni.c
+++ b/drivers/net/dpaa2/mc/dpni.c
@@ -1803,10 +1803,13 @@ int dpni_set_congestion_notification(struct fsl_mc_io *mc_io,
cmd_params->qtype = qtype;
cmd_params->tc = tc_id;
cmd_params->congestion_point = cfg->cg_point;
- cmd_params->cgid = (uint8_t)cfg->cgid;
- cmd_params->dest_id = cpu_to_le32(cfg->dest_cfg.dest_id);
+ if (cfg->cg_point == DPNI_CP_CONGESTION_GROUP)
+ cmd_params->cgid = (uint8_t)cfg->cgid;
+ if (cfg->dest_cfg.dest_type != DPNI_DEST_NONE) {
+ cmd_params->dest_id = cpu_to_le32(cfg->dest_cfg.dest_id);
+ cmd_params->dest_priority = cfg->dest_cfg.priority;
+ }
cmd_params->notification_mode = cpu_to_le16(cfg->notification_mode);
- cmd_params->dest_priority = cfg->dest_cfg.priority;
cmd_params->message_iova = cpu_to_le64(cfg->message_iova);
cmd_params->message_ctx = cpu_to_le64(cfg->message_ctx);
cmd_params->threshold_entry = cpu_to_le32(cfg->threshold_entry);
--
2.17.1
next prev parent reply other threads:[~2019-09-05 9:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 9:32 [dpdk-dev] [PATCH 00/10] Add an option to use LTO for DPDK build Andrzej Ostruszka
2019-09-05 9:32 ` [dpdk-dev] [PATCH 01/10] build: add an option to enable LTO build Andrzej Ostruszka
2019-09-05 9:36 ` Bruce Richardson
2019-09-05 9:43 ` Andrzej Ostruszka
2019-09-05 9:51 ` Bruce Richardson
2019-09-05 9:32 ` [dpdk-dev] [PATCH 02/10] eventdev: fix possible use of uninitialized var Andrzej Ostruszka
2019-09-05 9:32 ` [dpdk-dev] [PATCH 03/10] app/eventdev: fix maybe-uninitialized warnings for LTO build Andrzej Ostruszka
2019-09-05 9:32 ` [dpdk-dev] [PATCH 04/10] event/octeontx2: " Andrzej Ostruszka
2019-09-05 9:32 ` [dpdk-dev] [PATCH 05/10] app/test: " Andrzej Ostruszka
2019-09-05 13:25 ` Chas Williams
2019-09-17 10:41 ` Andrzej Ostruszka
2019-09-05 9:32 ` Andrzej Ostruszka [this message]
2019-09-05 9:32 ` [dpdk-dev] [PATCH 07/10] net/e1000: " Andrzej Ostruszka
2019-09-05 9:32 ` [dpdk-dev] [PATCH 08/10] net/i40e: " Andrzej Ostruszka
2019-09-05 9:32 ` [dpdk-dev] [PATCH 09/10] net/ifc: " Andrzej Ostruszka
2019-09-05 9:32 ` [dpdk-dev] [PATCH 10/10] net/qede: " Andrzej Ostruszka
[not found] <20190905092001.26011-1-amo@semihalf.com>
[not found] ` <20190905092001.26011-7-amo@semihalf.com>
[not found] ` <VI1PR0401MB25419AE95E8E6BCE90FE8F0C89BB0@VI1PR0401MB2541.eurprd04.prod.outlook.com>
2019-09-05 16:04 ` [dpdk-dev] [PATCH 06/10] net/dpaa2: fix possible use of uninitialized vars Andrzej Ostruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190905093239.27187-7-amo@semihalf.com \
--to=amo@semihalf.com \
--cc=aostruszka@marvell.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).