From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F76DA2E1B for ; Thu, 5 Sep 2019 11:51:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 240CB2BEA; Thu, 5 Sep 2019 11:51:07 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 1054C29CB for ; Thu, 5 Sep 2019 11:51:04 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Sep 2019 02:51:03 -0700 X-IronPort-AV: E=Sophos;i="5.64,470,1559545200"; d="scan'208";a="182777684" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.46]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Sep 2019 02:51:03 -0700 Date: Thu, 5 Sep 2019 10:51:00 +0100 From: Bruce Richardson To: Andrzej Ostruszka Cc: dev@dpdk.org Message-ID: <20190905095100.GA1157@bricha3-MOBL.ger.corp.intel.com> References: <20190905093239.27187-1-amo@semihalf.com> <20190905093239.27187-2-amo@semihalf.com> <20190905093618.GA1152@bricha3-MOBL.ger.corp.intel.com> <58aaaf93-35c7-f6cb-4a07-8e519d42b614@semihalf.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <58aaaf93-35c7-f6cb-4a07-8e519d42b614@semihalf.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH 01/10] build: add an option to enable LTO build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Sep 05, 2019 at 11:43:30AM +0200, Andrzej Ostruszka wrote: > On 9/5/19 11:36 AM, Bruce Richardson wrote: > > Should not need a new option here. There is already a built-in option > > "b_lto" which we can reuse. > > Thank you Bruce, I don't know much about meson so I missed that. > Will try to figure out how to use that. > No problem. The options are documented here: https://mesonbuild.com/Builtin-options.html and you can query them just the same as with the options added for the project. Therefore, the only thing that really should change is that in the meson.build file you check the built-in option and add the fat-lto-objects flag. Incidentally, I think if the fat-lto-objects flag is not supported you may want to error out if lto is enabled, as meson will add the lto flag itself if the option is set. Regards, /Bruce