From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED0E0A2EDB for ; Thu, 5 Sep 2019 22:23:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EAA7B1F094; Thu, 5 Sep 2019 22:23:55 +0200 (CEST) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 201671F090 for ; Thu, 5 Sep 2019 22:23:55 +0200 (CEST) Received: by mail-pg1-f196.google.com with SMTP id u72so2065195pgb.10 for ; Thu, 05 Sep 2019 13:23:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ReIXrvbyQSxSfsZ521hsvi0l9vVaZwKPLV47SpUMAUY=; b=El4glQeI8trQpmp0fJ3/xHqqxdUNsusrwWQFwXxdjY8RBpJApxoZvo264jB/80/EgV 1vnfnDi7XITinuu19/VYEDRc6oj1oH/E3xiQHwcVZlsUW01SKkLVdTXsvBLH7Q1kv3PN m2XmMou2EE3hL7B+G+Mv2OAe9YdEdVOvakLssvKoF7Ois3mRVfxxlj6DfkoUskUezzv5 /ZS08C8Rpy1HYL7YNnFYuzP6oKit3SuwsIYWx0uO7wxUGUhZkM5ldYiNt9xdr7bEg+uE MEtHOfK52ZLnJwmaTB70XLZd0YKgf85F9E5TSufUxKuxadrLUiUAZ0FJDJLfaoMSDyh9 aigQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ReIXrvbyQSxSfsZ521hsvi0l9vVaZwKPLV47SpUMAUY=; b=rLyZJBJRnz5C8qKSC+vN2h1ogLgMAYKk41dJD5s81AcGrMq1h/MBsqJf0epo4YKZt1 PoMWQr0bstD4h+HwkY4696IymlFQMjI9U6vrykW7EIlNITooXQmLjzOpjweTVBY0x7FJ MRgHuHd52w0hvaZ/knwE+ljDmaiS2xS2A5OX2Skidtldv5XalVJXI76+rV0PqCFgzlFy f8IBb7oF0p+yaPbqcFaKTbjnoU+UjnLXqAG6E0LBAMmleTggZ+0mfN5Oc/LlQD86Ecq2 o+hYCauS2NrJ5M4iu997S6iJx7cIekB47qZPfgZiHtZPeS0b4eGd4L5i74pMjr6icE4L f1fg== X-Gm-Message-State: APjAAAXanR7+p0VCUa5AN+/FfgTPXO0ZzNmu8399LqyBdEPgYr1ToLE6 d8l3z/SLLCLXf/EksUJxdsPoXQ== X-Google-Smtp-Source: APXvYqw7H5/uBR52zTYh1D2h4ynNn8dzSin0/9TIF/IAdXyAq4HJBgz8XCO1cHEHQ/ukySbRcN7l9g== X-Received: by 2002:a17:90a:36ae:: with SMTP id t43mr5876899pjb.7.1567715034055; Thu, 05 Sep 2019 13:23:54 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id v10sm2779865pjk.23.2019.09.05.13.23.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Sep 2019 13:23:53 -0700 (PDT) Date: Thu, 5 Sep 2019 13:23:50 -0700 From: Stephen Hemminger To: Dharmik Thakkar Cc: Wenzhuo Lu , Konstantin Ananyev , dev , Honnappa Nagarahalli , "Ruifeng Wang (Arm Technology China)" , nd Message-ID: <20190905132350.4c0708d0@hermes.lan> In-Reply-To: <92C6BFD2-6165-44D1-99CA-D0290DD197CD@arm.com> References: <20190901065810.15137-1-dharmik.thakkar@arm.com> <20190901065810.15137-2-dharmik.thakkar@arm.com> <20190905082647.63966b21@hermes.lan> <92C6BFD2-6165-44D1-99CA-D0290DD197CD@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [RFC 1/3] net/ixgbe: avoid multpile definitions of 'bool' X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 5 Sep 2019 20:10:05 +0000 Dharmik Thakkar wrote: > > On Sep 5, 2019, at 10:26 AM, Stephen Hemminger wrote: > >=20 > > On Sun, 1 Sep 2019 06:58:08 +0000 > > Dharmik Thakkar wrote: > > =20 > >> Compilation issue arises due to multiple definitions of 'bool' > >> in 'ixgbe_ethdev.h'. > >> (Please note that this issue showed up when 'rte_rcu_qsbr.h' got inclu= ded > >> within 'rte_hash.h', because 'rte_rcu_qsbr.h' includes 'stdbool.h'. Th= is > >> is a temporary fix. Recommend suggesting better solution.) > >>=20 > >> Signed-off-by: Dharmik Thakkar > >> --- > >> drivers/net/ixgbe/ixgbe_ethdev.h | 1 + > >> 1 file changed, 1 insertion(+) > >>=20 > >> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.h b/drivers/net/ixgbe/ixgb= e_ethdev.h > >> index 6e9ed2e10f3c..dd4d6c022545 100644 > >> --- a/drivers/net/ixgbe/ixgbe_ethdev.h > >> +++ b/drivers/net/ixgbe/ixgbe_ethdev.h > >> @@ -18,6 +18,7 @@ > >> #include > >> #include > >> #include > >> +#undef bool > >> #include > >> #include > >> #include =20 > >=20 > > Just fix ixgbe_ethdev.h to include stdbool itself? =20 > Conflicts with 'typedef int bool;=E2=80=99 in ixgbe_osdep.h:86 Then fix the ixgbe_osdep.h. It is the problem.