DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: bluca@debian.org, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] devtools: fix check of ccache for meson build
Date: Fri, 13 Sep 2019 10:54:23 +0100	[thread overview]
Message-ID: <20190913095422.GB1921@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20190913073425.13363-1-thomas@monjalon.net>

On Fri, Sep 13, 2019 at 09:34:25AM +0200, Thomas Monjalon wrote:
> The meson build test fails if ccache is not available.
> The use of ccache must be optional.
> And if used, the compiler to check is the last word of $CC.
> 
> Fixes: e0ae780e6569 ("devtools: test compiler availability only once")
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> 
> ---
> 
> This script is failing now because a real check of ccache availability
> is done in commit e0ae780e6569.
> It was not failing before, which means $CC is not used by meson?

$CC is used, otherwise we wouldn't be able to do any clang builds. :-)

I think what used to happen with earlier versions of the script was that
large chunks of the builds used to be skipped if ccache wasn't available,
i.e. I think it used to just do the "default" build and skip the regular
clang/gcc builds as those were where we checked for compiler presence.
[NOTE: it's been a while since I ran this on a system without ccache and I
never got to fixing it when I did encounter one - installing ccache was
always the easier step. :-)]

      parent reply	other threads:[~2019-09-13  9:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-13  7:34 Thomas Monjalon
2019-09-13  9:46 ` Luca Boccassi
2019-09-13 10:33   ` Thomas Monjalon
2019-09-13  9:54 ` Bruce Richardson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190913095422.GB1921@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=bluca@debian.org \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).