From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 76236A2EEB
for <public@inbox.dpdk.org>; Sat, 14 Sep 2019 11:37:29 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 48AD51EB22;
Sat, 14 Sep 2019 11:37:29 +0200 (CEST)
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
[66.111.4.29]) by dpdk.org (Postfix) with ESMTP id E5E2D1EB09;
Sat, 14 Sep 2019 11:37:26 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 6B8C921368;
Sat, 14 Sep 2019 05:37:25 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute1.internal (MEProxy); Sat, 14 Sep 2019 05:37:25 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding; s=mesmtp; bh=AvElL286BF
QPiUL/tInjqvxY40I97SCECKH6NTBpr/k=; b=Isp0U8iHK7y8RZq64gAW6HhhJF
Kb3JTwFZBgnNfPvKNxfsHMQFftzoqQ7970NrPzzNAZXEfzfOty+8o5Xf2OoNNFUT
yxGX43N0kb7j4q9sq7xcWmDHIUlnuPC6dkMPhi8AwsIMuYSLuNNJqvF/7PIeeUWV
GdFuz8qDqo1nUtBxw=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:date:from
:in-reply-to:message-id:mime-version:references:subject:to
:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
fm3; bh=AvElL286BFQPiUL/tInjqvxY40I97SCECKH6NTBpr/k=; b=fiGEt7mV
AAJ1ZXY8wcj3zoLSPKk+sGeMOwzjSwM0sp2+FRhyUsxJXUICwwRLpnugBbYf75XW
dzNXpNTPAH9wIKzqTqgkfdxoqFO/WUZk5vKHlFBvMjVOzDMHWzMMVK+lOLZyj1YT
7wgaofSInd5J2wqaeexu64eCJnLAlDH/n6Pyr66HVoEgZBwkPwiXwHxtgbfHCqav
mFM0zZNJIaWEitaGyaSIRefMIEPJHfis+mHcvoSqDZT1D5xxjE1izrmqbmP2MoXW
xzLpbfqQbYPl9KbUJkAGrgF72/xGVRGReLDoO56vWt38RT/EMDbHz+L52agfT56P
91gP/sDJvEKUrQ==
X-ME-Sender: <xms:1bR8XWCvqwVgRgSc2zl7CwFuStRH9QojJDtO88aor6fkavFrfLhxTw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrtdelgddukecutefuodetggdotefrodftvf
curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhmrghs
ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph
epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho
mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd
X-ME-Proxy: <xmx:1bR8Xf5CXlfDySvPhmP21b3TeKofhntStphDiLvevB-7qZ5BIH9pxg>
<xmx:1bR8XcImVKsjYKzLXBj8VPmqgDoyqOKXxa1y8kJW3ka4ss-D0uZmrQ>
<xmx:1bR8XV-R3rCEk1Wn5H2TX0uSKyjQktTzzEg5b4xHQCUZgVvN_mIPmg>
<xmx:1bR8Xbu-uo8XcGa-XS0aKa4GspuHAyiVlK9vlM8aEQT0xA8CmtEzKw>
Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 77579D6005A;
Sat, 14 Sep 2019 05:37:24 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: bruce.richardson@intel.com, Rastislav Cernay <cernay@netcope.com>,
Jan Remes <remes@netcope.com>
Cc: dev@dpdk.org,
stable@dpdk.org
Date: Sat, 14 Sep 2019 11:36:59 +0200
Message-Id: <20190914093700.11451-2-thomas@monjalon.net>
X-Mailer: git-send-email 2.23.0
In-Reply-To: <20190914093700.11451-1-thomas@monjalon.net>
References: <20190914093700.11451-1-thomas@monjalon.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [dpdk-dev] [PATCH 1/2] net/nfb: fix dependency check
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
The library libnfb is part of netcope-common which provides
a pkg-config file: netcope-common.pc.
Looking for this .pc file - with dependency() - is preferred
than looking for the library - with cc.find_library().
If the library is not installed in a standard path,
it can be found thanks to PKG_CONFIG_PATH variable.
The previous solution required to use CFLAGS and LDFLAGS
environment variables.
Fixes: 6435f9a0ac22 ("net/nfb: add new netcope driver")
Cc: stable@dpdk.org
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
drivers/net/nfb/meson.build | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/net/nfb/meson.build b/drivers/net/nfb/meson.build
index 4502c3f76..d53e8eca7 100644
--- a/drivers/net/nfb/meson.build
+++ b/drivers/net/nfb/meson.build
@@ -3,14 +3,9 @@
# Copyright(c) 2019 Netcope Technologies, a.s. <info@netcope.com>
# All rights reserved.
-dep = cc.find_library('nfb', required: false)
+dep = dependency('netcope-common', required: false)
reason = 'missing dependency, "libnfb"'
-
-build = dep.found() and cc.has_header('nfb/nfb.h', dependencies: dep)
-
-nc = dependency('netcope-common', required: false)
-
+build = dep.found()
ext_deps += dep
-ext_deps += nc
sources = files('nfb_rx.c', 'nfb_tx.c', 'nfb_stats.c', 'nfb_ethdev.c', 'nfb_rxmode.c')
--
2.23.0