From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 553BCA0613
	for <public@inbox.dpdk.org>; Mon, 23 Sep 2019 10:31:58 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 2F5391BEB8;
	Mon, 23 Sep 2019 10:31:58 +0200 (CEST)
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id CFA7F1BEAD
 for <dev@dpdk.org>; Mon, 23 Sep 2019 10:31:56 +0200 (CEST)
X-Amp-Result: UNKNOWN
X-Amp-Original-Verdict: FILE UNKNOWN
X-Amp-File-Uploaded: False
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 23 Sep 2019 01:31:55 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,539,1559545200"; d="scan'208";a="272209462"
Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17])
 by orsmga001.jf.intel.com with ESMTP; 23 Sep 2019 01:31:54 -0700
Date: Mon, 23 Sep 2019 16:29:51 +0800
From: Ye Xiaolong <xiaolong.ye@intel.com>
To: "Yang, Qiming" <qiming.yang@intel.com>
Cc: "Rong, Leyi" <leyi.rong@intel.com>, "Wang, Haiyue" <haiyue.wang@intel.com>,
 "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
 "Zhang, Qi Z" <qi.z.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Message-ID: <20190923082951.GB5202@intel.com>
References: <20190829023421.112551-1-leyi.rong@intel.com>
 <20190919062553.79257-1-leyi.rong@intel.com>
 <20190919062553.79257-4-leyi.rong@intel.com>
 <F5DF4F0E3AFEF648ADC1C3C33AD4DBF17A53F289@SHSMSX101.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <F5DF4F0E3AFEF648ADC1C3C33AD4DBF17A53F289@SHSMSX101.ccr.corp.intel.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Subject: Re: [dpdk-dev] [PATCH v4 3/6] net/ice: add protocol extraction
 support	for per Rx queue
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 09/23, Yang, Qiming wrote:
>
>

[snip]

>> @@ -1378,9 +1666,18 @@ static int ice_parse_devargs(struct rte_eth_dev
>> *dev)
>>  		return -EINVAL;
>>  	}
>> 
>> +	memset(ad->devargs.proto_xtr, PROTO_XTR_NONE,
>> +	       sizeof(ad->devargs.proto_xtr));
>> +
>> +	ret = rte_kvargs_process(kvlist, ICE_PROTO_XTR_ARG,
>> +				 &handle_proto_xtr_arg, &ad->devargs);
>> +	if (ret)
>> +		goto bail;
>> +
>
>Why is bail?
>

Minor nit, better to snip unrelated context for one single comment, otherwise
it's quite difficult to find it. :)

Thanks,
Xiaolong