From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 116D3A0613
	for <public@inbox.dpdk.org>; Mon, 23 Sep 2019 17:57:44 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id BD9611BF28;
	Mon, 23 Sep 2019 17:57:43 +0200 (CEST)
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 3187E1BF25
 for <dev@dpdk.org>; Mon, 23 Sep 2019 17:57:42 +0200 (CEST)
X-Amp-Result: UNKNOWN
X-Amp-Original-Verdict: FILE UNKNOWN
X-Amp-File-Uploaded: False
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 23 Sep 2019 08:57:41 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,541,1559545200"; d="scan'208";a="190714371"
Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17])
 by orsmga003.jf.intel.com with ESMTP; 23 Sep 2019 08:57:40 -0700
Date: Mon, 23 Sep 2019 23:55:36 +0800
From: Ye Xiaolong <xiaolong.ye@intel.com>
To: "Wang, Haiyue" <haiyue.wang@intel.com>
Cc: "Rong, Leyi" <leyi.rong@intel.com>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
 "Zhang, Qi Z" <qi.z.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Message-ID: <20190923155536.GC15446@intel.com>
References: <20190829023421.112551-1-leyi.rong@intel.com>
 <20190919062553.79257-1-leyi.rong@intel.com>
 <20190919062553.79257-4-leyi.rong@intel.com>
 <20190923142424.GB15446@intel.com>
 <E3B9F2FDCB65864C82CD632F23D8AB8773D6CA5E@shsmsx102.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <E3B9F2FDCB65864C82CD632F23D8AB8773D6CA5E@shsmsx102.ccr.corp.intel.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Subject: Re: [dpdk-dev] [PATCH v4 3/6] net/ice: add protocol extraction
 support for per Rx queue
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 09/23, Wang, Haiyue wrote:

>> >+{
>> >+	static uint8_t rxdid_map[] = {
>Add this line:
>		[PROTO_XTR_NONE]      = ICE_RXDID_COMMS_GENERIC,

This makes sense.

>> >+		[PROTO_XTR_VLAN]      = ICE_RXDID_COMMS_AUX_VLAN,
>> >+		[PROTO_XTR_IPV4]      = ICE_RXDID_COMMS_AUX_IPV4,
>> >+		[PROTO_XTR_IPV6]      = ICE_RXDID_COMMS_AUX_IPV6,
>> >+		[PROTO_XTR_IPV6_FLOW] = ICE_RXDID_COMMS_AUX_IPV6_FLOW,
>> >+		[PROTO_XTR_TCP]       = ICE_RXDID_COMMS_AUX_TCP,
>> >+	};
>> >+	uint8_t rxdid;
>> >+
>> >+	rxdid = xtr_tpye < RTE_DIM(rxdid_map) ? rxdid_map[xtr_tpye] : 0;
>> >+
>> >+	return rxdid != 0 ? rxdid : ICE_RXDID_COMMS_GENERIC;
>> 
>> Maybe just
>> 
>> 	return xtr_type < RTE_DIM(rxdid_map) ?
>> 				rxdid_map[xtr_type] : ICE_RXDID_COMMS_GENERIC;
>> 
>
>Then this, will be updated in next version.
>
>> as previous ice_rxdid_to_proto_xtr_type.
>> 
>> 
>> Thanks,
>> Xiaolong