From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 6AF6EA0613
for <public@inbox.dpdk.org>; Tue, 24 Sep 2019 17:20:05 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 1291A2BEA;
Tue, 24 Sep 2019 17:20:03 +0200 (CEST)
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
by dpdk.org (Postfix) with ESMTP id 7D0592B94;
Tue, 24 Sep 2019 17:20:00 +0200 (CEST)
X-Amp-Result: UNKNOWN
X-Amp-Original-Verdict: FILE UNKNOWN
X-Amp-File-Uploaded: False
Received: from orsmga006.jf.intel.com ([10.7.209.51])
by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
24 Sep 2019 08:19:59 -0700
X-IronPort-AV: E=Sophos;i="5.64,544,1559545200"; d="scan'208";a="193473906"
Received: from gmcdermo-mobl.ger.corp.intel.com (HELO
bricha3-MOBL.ger.corp.intel.com) ([10.252.7.73])
by orsmga006-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
24 Sep 2019 08:19:58 -0700
Date: Tue, 24 Sep 2019 16:19:55 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: stable@dpdk.org, Cristian Bidea <cristian.bidea@keysight.com>
Message-ID: <20190924151955.GA880@bricha3-MOBL.ger.corp.intel.com>
References: <bug-351-3@http.bugs.dpdk.org/>
<20190924120414.67793-1-bruce.richardson@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190924120414.67793-1-bruce.richardson@intel.com>
User-Agent: Mutt/1.11.4 (2019-03-13)
Subject: Re: [dpdk-dev] [PATCH] port: fix missing pcap support with meson
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Tue, Sep 24, 2019 at 01:04:14PM +0100, Bruce Richardson wrote:
> The meson build was missing the define to enable pcap port support if
> libpcap (development) package was found on the build platform. Rather than
> duplicating the checks for libpcap found in the pcap net PMD build file, we
> can move the checks to the top-level config directory and reference the
> RTE_PCAP_PORT setting elsewhere in the build.
>
> Bugzilla ID: 351
> Fixes: 5b9656b157d3 ("lib: build with meson")
>
> Cc: stable@dpdk.org
> Reported-by: Cristian Bidea <cristian.bidea@keysight.com>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Based on response given in bugzilla
[https://bugs.dpdk.org/show_bug.cgi?id=351]
Tested-by: Cristian Bidea <cristian.bidea@keysight.com>
Just adding here so it shows up in patchwork.
/Bruce