From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BB917A0613 for ; Thu, 26 Sep 2019 01:37:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CD0BD1DBD; Thu, 26 Sep 2019 01:37:07 +0200 (CEST) Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id 9DBA41E25 for ; Thu, 26 Sep 2019 01:37:06 +0200 (CEST) Received: by mail-pf1-f194.google.com with SMTP id q12so503172pff.9 for ; Wed, 25 Sep 2019 16:37:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sOhhyIFJZtS//AMg9gtn+gcmZOhz+3jMtQst0BGM/F4=; b=lJx7OGawPbmbrCRKtaYoY08glSCe09AuCNqKs2rC4f+Nb8MSRXvXvlnXbGdMwWvZVv knyn0iEtsUfztrT+udeOTIizpBWJUbEBrfJxQQR1w4FkoOMileGdzME6T4s3meKl94Tj s2VBnTJuXFgFwTXCDYjG7iJFrEfZDtn2AA1CuROQW9uxfxBLGjxoUHKyZRrDfJjWyl9w RFONOJjqSV87RqnbRE6GPaVffW7i03ZGyIbHPx64Of6yov94XoeLUeqikE6c0KvjARkd E05bOBJzXEKhCcUtuy8FEpVyuuhjjbkIJGFeNsei31lfpX5WhvRiM2Hbix4Ja28dMxZe Od8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sOhhyIFJZtS//AMg9gtn+gcmZOhz+3jMtQst0BGM/F4=; b=poPd5uRhNIoIUo+/dY+Ipui3dKSaRBjTTc3qvQfRrglWVrVCNHmNvN5NMjChXIGm1A D2XEMM4p+rYa4z4iY40MzzMYT1gYf/9uQkTcxdM/PWrLnwD80Pe2uzERmjWPyCRU1/ol X1CPauD96ozdKPD266HCbmMQ6MXwBLK8EkEQ4r+rh/IHuxb7gUbgQhioHaDKZM1A8vd9 RcOeVST/ARY9e28Wkey3Izv3UUaqK/IUJSIE/d9arDhA2jZuvydFBvScmtUFdFLuMb9e fzextCfcbaqforqXvd4CLg/6brLvb57EPDzuxAjI6CXGtzrjR0+TT0zcw/3ubU1wlnku iu7g== X-Gm-Message-State: APjAAAUtDgygEmHmBwdngbfcqAJlB7DtWLSl7kSQyr2h+O+D3Gl1yU0M oXoBYZQmQcNmfe8164EtgmEKKGCCF8k= X-Google-Smtp-Source: APXvYqwJ8PCkmjNRwa+yHjW4/lgvTPeBYk9bEb92caAu+EYPyZ7KM0oe3lqL1FYKIuzVWBTVxwpZUA== X-Received: by 2002:a62:fc46:: with SMTP id e67mr284499pfh.153.1569454625429; Wed, 25 Sep 2019 16:37:05 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id e184sm129595pfa.87.2019.09.25.16.37.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Sep 2019 16:37:05 -0700 (PDT) Date: Wed, 25 Sep 2019 16:37:01 -0700 From: Stephen Hemminger To: Morten =?UTF-8?B?QnLDuHJ1cA==?= Cc: "Thomas Monjalon" , , , "dpdk-dev" Message-ID: <20190925163701.78c09842@hermes.lan> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35B42ACC@smartserver.smartshare.dk> References: <20190925120355.44821-3-mb@smartsharesystems.com> <20190925120542.A51B41BE84@dpdk.org> <98CBD80474FA8B44BF855DF32C47DC35B42ACC@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] |WARNING| pw59738 [PATCH v2 2/2] mbuf: add bulk free function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 25 Sep 2019 14:17:42 +0200 Morten Br=C3=B8rup wrote: > Dear Thomas - listed as checkpatch maintainer, >=20 > I think this warning is bogus, and is a bug checkpatch. >=20 > The line in question was deliberately indented using tabs to the current = indentation level, and using spaces for the readability alignment. This mak= es the code readable in editors with another tab setting than 8 spaces. E.g= . 4 spaces is my personal preference. >=20 >=20 > Med venlig hilsen / kind regards > - Morten Br=C3=B8rup It is understandable that you have personal preferences, but projects like = DPDK rely on common style across all code. The collective decision has been made to k= eep a uniform style similar to the Linux kernel. No it is not a bug in checkpatch.