* [dpdk-dev] [DPDK] app/testpmd: fix unused variable compile error
@ 2019-09-25 17:54 taox.zhu
2019-09-25 10:34 ` Andrew Rybchenko
2019-09-25 18:03 ` [dpdk-dev] [PATCH v2] " taox.zhu
0 siblings, 2 replies; 5+ messages in thread
From: taox.zhu @ 2019-09-25 17:54 UTC (permalink / raw)
To: wenzhuo.lu, jingjing.wu, bernard.iremonger; +Cc: dev, ivan.ilchenko, Zhu Tao
From: Zhu Tao <taox.zhu@intel.com>
This minor patch fixes unused variable ‘ret’ compile error When
CONFIG_RTE_LIBRTE_I40E_16BYTE_RX_DESC was selected.
Fixes: f5267e485a2a ("app/testpmd: check status of getting ethdev info")
Signed-off-by: Zhu Tao <taox.zhu@intel.com>
---
app/test-pmd/config.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 957c61fbe..a3b6cbd08 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -1649,10 +1649,10 @@ ring_rx_descriptor_display(const struct rte_memzone *ring_mz,
#endif
uint16_t desc_id)
{
- int ret;
struct igb_ring_desc_16_bytes *ring =
(struct igb_ring_desc_16_bytes *)ring_mz->addr;
#ifndef RTE_LIBRTE_I40E_16BYTE_RX_DESC
+ int ret;
struct rte_eth_dev_info dev_info;
ret = eth_dev_info_get_print_err(port_id, &dev_info);
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [DPDK] app/testpmd: fix unused variable compile error
2019-09-25 17:54 [dpdk-dev] [DPDK] app/testpmd: fix unused variable compile error taox.zhu
@ 2019-09-25 10:34 ` Andrew Rybchenko
2019-09-25 18:03 ` [dpdk-dev] [PATCH v2] " taox.zhu
1 sibling, 0 replies; 5+ messages in thread
From: Andrew Rybchenko @ 2019-09-25 10:34 UTC (permalink / raw)
To: taox.zhu, wenzhuo.lu, jingjing.wu, bernard.iremonger; +Cc: dev, ivan.ilchenko
On 9/25/19 8:54 PM, taox.zhu@intel.com wrote:
> From: Zhu Tao <taox.zhu@intel.com>
>
> This minor patch fixes unused variable ‘ret’ compile error When
> CONFIG_RTE_LIBRTE_I40E_16BYTE_RX_DESC was selected.
>
> Fixes: f5267e485a2a ("app/testpmd: check status of getting ethdev info")
>
> Signed-off-by: Zhu Tao <taox.zhu@intel.com>
Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>
Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread* [dpdk-dev] [PATCH v2] app/testpmd: fix unused variable compile error
2019-09-25 17:54 [dpdk-dev] [DPDK] app/testpmd: fix unused variable compile error taox.zhu
2019-09-25 10:34 ` Andrew Rybchenko
@ 2019-09-25 18:03 ` taox.zhu
2019-09-26 1:33 ` Zhang, Qi Z
1 sibling, 1 reply; 5+ messages in thread
From: taox.zhu @ 2019-09-25 18:03 UTC (permalink / raw)
To: wenzhuo.lu, jingjing.wu, bernard.iremonger; +Cc: dev, ivan.ilchenko, Zhu Tao
From: Zhu Tao <taox.zhu@intel.com>
This minor patch fixes unused variable ‘ret’ compile error When
CONFIG_RTE_LIBRTE_I40E_16BYTE_RX_DESC was selected.
Fixes: f5267e485a2a ("app/testpmd: check status of getting ethdev info")
Signed-off-by: Zhu Tao <taox.zhu@intel.com>
---
app/test-pmd/config.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 957c61fbe..a3b6cbd08 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -1649,10 +1649,10 @@ ring_rx_descriptor_display(const struct rte_memzone *ring_mz,
#endif
uint16_t desc_id)
{
- int ret;
struct igb_ring_desc_16_bytes *ring =
(struct igb_ring_desc_16_bytes *)ring_mz->addr;
#ifndef RTE_LIBRTE_I40E_16BYTE_RX_DESC
+ int ret;
struct rte_eth_dev_info dev_info;
ret = eth_dev_info_get_print_err(port_id, &dev_info);
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH v2] app/testpmd: fix unused variable compile error
2019-09-25 18:03 ` [dpdk-dev] [PATCH v2] " taox.zhu
@ 2019-09-26 1:33 ` Zhang, Qi Z
2019-09-26 10:04 ` Ferruh Yigit
0 siblings, 1 reply; 5+ messages in thread
From: Zhang, Qi Z @ 2019-09-26 1:33 UTC (permalink / raw)
To: Zhu, TaoX, Lu, Wenzhuo, Wu, Jingjing, Iremonger, Bernard
Cc: dev, ivan.ilchenko, Zhu, TaoX
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of taox.zhu@intel.com
> Sent: Thursday, September 26, 2019 2:03 AM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Iremonger, Bernard <bernard.iremonger@intel.com>
> Cc: dev@dpdk.org; ivan.ilchenko@oktetlabs.com; Zhu, TaoX
> <taox.zhu@intel.com>
> Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix unused variable compile error
>
> From: Zhu Tao <taox.zhu@intel.com>
>
> This minor patch fixes unused variable ‘ret’ compile error When
> CONFIG_RTE_LIBRTE_I40E_16BYTE_RX_DESC was selected.
>
> Fixes: f5267e485a2a ("app/testpmd: check status of getting ethdev info")
>
> Signed-off-by: Zhu Tao <taox.zhu@intel.com>
Reviewed-by: Qi Zhang <qi.z.zhang@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH v2] app/testpmd: fix unused variable compile error
2019-09-26 1:33 ` Zhang, Qi Z
@ 2019-09-26 10:04 ` Ferruh Yigit
0 siblings, 0 replies; 5+ messages in thread
From: Ferruh Yigit @ 2019-09-26 10:04 UTC (permalink / raw)
To: Zhang, Qi Z, Zhu, TaoX, Lu, Wenzhuo, Wu, Jingjing, Iremonger, Bernard
Cc: dev, ivan.ilchenko
On 9/26/2019 2:33 AM, Zhang, Qi Z wrote:
>
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of taox.zhu@intel.com
>> Sent: Thursday, September 26, 2019 2:03 AM
>> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
>> <jingjing.wu@intel.com>; Iremonger, Bernard <bernard.iremonger@intel.com>
>> Cc: dev@dpdk.org; ivan.ilchenko@oktetlabs.com; Zhu, TaoX
>> <taox.zhu@intel.com>
>> Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix unused variable compile error
>>
>> From: Zhu Tao <taox.zhu@intel.com>
>>
>> This minor patch fixes unused variable ‘ret’ compile error When
>> CONFIG_RTE_LIBRTE_I40E_16BYTE_RX_DESC was selected.
>>
>> Fixes: f5267e485a2a ("app/testpmd: check status of getting ethdev info")
>>
>> Signed-off-by: Zhu Tao <taox.zhu@intel.com>
>
> Reviewed-by: Qi Zhang <qi.z.zhang@intel.com>
>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-09-26 10:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-25 17:54 [dpdk-dev] [DPDK] app/testpmd: fix unused variable compile error taox.zhu
2019-09-25 10:34 ` Andrew Rybchenko
2019-09-25 18:03 ` [dpdk-dev] [PATCH v2] " taox.zhu
2019-09-26 1:33 ` Zhang, Qi Z
2019-09-26 10:04 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).