From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CE596A0613 for ; Thu, 26 Sep 2019 18:09:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4C0B82C30; Thu, 26 Sep 2019 18:09:32 +0200 (CEST) Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id AD6462C2F for ; Thu, 26 Sep 2019 18:09:30 +0200 (CEST) Received: by mail-pg1-f194.google.com with SMTP id q7so1787935pgi.12 for ; Thu, 26 Sep 2019 09:09:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=t8IVOY3PRuvtxiQW+o/yPV930ZR1/k2fV1l8iicVlx4=; b=ohx4mb/TsWXbBTF4OOyqSueAq0J5d8Yzdr2UgJ4FOja5onHoDICpe17YUji3qc1xvt LiHlwDJwBzXumKp4Ie4zq/b+cFqnY3DMD6J1BuBYDF5LvpCwwu1/Huf1rOOKsggXGzLu ZKebC+Jtr0kzq2vI8oNXvbKR+ll+ws2rJ/LQw5fApP0K0KARKBDoWLtO1EiBOh08MaPr 1CZzjdGXozJdgANKQNlz3PZ9IilYsdP/FILEgvf4tmiwiqSGe/F27GLOMiMc64UDdM4q 3kAZ5b3J0Ifv5JBY0l7c7YwYT/ppuxnAb+R8emhtAHHjtAlV99Wxh+9bgFH/vc8+JgC8 G02Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=t8IVOY3PRuvtxiQW+o/yPV930ZR1/k2fV1l8iicVlx4=; b=gAKaz6y6A8VJKks8o1Vj8/sP9/gtNxb4PKhsLFwb4pRoWizxQ39G8IpImw6AQtSdwd 7IM0Qx9USJuJI3Wtu7NwMgkx22Zb1qcz3c3+9XALhE7r+y0MwvRhEidCrb+2OG8KfqZx bKfnHB3ZeZXjfOhdFFvcFnLsPMpydkDS6uMYxy+LCzBe/qEhk7IfU7yImK4s9rg6W5ny oXESVS1RGASguqzAeHJU4y+qSJiHHmjO9Sjg1gJV+jFl6pGA5cgKZSKdHLu6orEbZ/G2 87B41X3nBO1N8IuC3+tD04LZ8sXFItway6g1sko+iQijzcGXfG9SUCVFIuWW8M1NiCMs Q8Bg== X-Gm-Message-State: APjAAAXK1fbzcTjMpVVj42Sis1ZCwkKK/yJxiGDaTfa98P91XaX37A/t hyvlVhAibBkiE5W/jg0FHRIK6g== X-Google-Smtp-Source: APXvYqwz9SQLqMIDIC8ip9HkyXZLFRYSOliWbnIzUGeRcan7nf8mm/hAPz9sYVzOG4P7oz/U+hM4MA== X-Received: by 2002:aa7:91d4:: with SMTP id z20mr4581687pfa.131.1569514169733; Thu, 26 Sep 2019 09:09:29 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id x20sm3211156pfp.120.2019.09.26.09.09.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Sep 2019 09:09:29 -0700 (PDT) Date: Thu, 26 Sep 2019 09:09:28 -0700 From: Stephen Hemminger To: Andrew Rybchenko Cc: Message-ID: <20190926090928.07e474fd@hermes.lan> In-Reply-To: <8c2d6a91-f5f1-57e0-61f7-8d07542ae305@solarflare.com> References: <20190811160607.16441-1-stephen@networkplumber.org> <20190919131729.28681-1-stephen@networkplumber.org> <20190919131729.28681-2-stephen@networkplumber.org> <8c2d6a91-f5f1-57e0-61f7-8d07542ae305@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 1/2] ethdev: expose basic xstats for driver use X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 26 Sep 2019 15:46:52 +0300 Andrew Rybchenko wrote: > On 9/19/19 4:17 PM, Stephen Hemminger wrote: > > Avoid duplication by having generic basic xstats available > > for use by drivers. A later patch uses this for failsafe > > driver. > > > > Signed-off-by: Stephen Hemminger > > Acked-by: Gaetan Rivet > > Acked-by: Andrew Rybchenko > > > diff --git a/lib/librte_ethdev/rte_ethdev_driver.h b/lib/librte_ethdev/rte_ethdev_driver.h > > index 936ff8c98651..489889a72203 100644 > > --- a/lib/librte_ethdev/rte_ethdev_driver.h > > +++ b/lib/librte_ethdev/rte_ethdev_driver.h > > @@ -208,6 +208,71 @@ rte_eth_linkstatus_get(const struct rte_eth_dev *dev, > > #endif > > } > > > > +/** > > + * @internal > > + * Get basic stats part of xstats for an ethernet device. > > + * > > + * @param dev > > + * Pointer to struct rte_eth_dev. > > + */ > > +__rte_experimental > > Does it make sense to mark internal API as experimental? > I thought that @internal is not a part of API/ABI. agree, but checkpatch doesn't understand @internal tag.