From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 03E37A0613
for <public@inbox.dpdk.org>; Fri, 27 Sep 2019 22:48:28 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 19CCB1BEF2;
Fri, 27 Sep 2019 22:48:27 +0200 (CEST)
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
by dpdk.org (Postfix) with ESMTP id 1B1B81BEF0
for <dev@dpdk.org>; Fri, 27 Sep 2019 22:48:24 +0200 (CEST)
X-Amp-Result: UNKNOWN
X-Amp-Original-Verdict: FILE UNKNOWN
X-Amp-File-Uploaded: False
Received: from orsmga003.jf.intel.com ([10.7.209.27])
by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
27 Sep 2019 13:48:23 -0700
X-IronPort-AV: E=Sophos;i="5.64,556,1559545200"; d="scan'208";a="193368464"
Received: from bricha3-mobl.ger.corp.intel.com ([10.252.31.249])
by orsmga003-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
27 Sep 2019 13:48:21 -0700
Date: Fri, 27 Sep 2019 21:48:16 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Andrzej Ostruszka <amo@semihalf.com>,
Thomas Monjalon <thomas@monjalon.net>, Ray Kinsella <mdr@ashroe.eu>,
Neil Horman <nhorman@tuxdriver.com>
Message-ID: <20190927204816.GA1875@bricha3-MOBL.ger.corp.intel.com>
References: <20190927194932.22197-1-bruce.richardson@intel.com>
<20190927194932.22197-2-bruce.richardson@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190927194932.22197-2-bruce.richardson@intel.com>
User-Agent: Mutt/1.11.4 (2019-03-13)
Subject: Re: [dpdk-dev] [PATCH 1/2] eal: split compat header file
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Fri, Sep 27, 2019 at 08:49:31PM +0100, Bruce Richardson wrote:
> The compat.h header file provided macros for two purposes:
> 1. it provided the macros for marking functions as rte_experimental
> 2. it provided the macros for doing function versioning
>
> Although these were in the same file, #1 is something that is for use by
> public header files, which #2 is for internal use only. Therefore, we can
> split these into two headers, keeping #1 in rte_compat.h and #2 in a new
> file rte_function_versioning.h. For "make" builds, since internal objects
> pick up the headers from the "include/" folder, we need to add the new
> header to the installation list, but for "meson" builds it does not need to
> be installed as it's not for public use.
>
> The rework also serves to allow the use of the function versioning macros
> to files that actually need them, so the use of experimental functions does
> not need including of the versioning code.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> doc/api/doxy-api-index.md | 3 ++-
> doc/guides/contributing/versioning.rst | 4 ++--
> lib/librte_distributor/rte_distributor.c | 2 +-
> lib/librte_distributor/rte_distributor_v20.c | 2 +-
> lib/librte_eal/common/Makefile | 1 +
> ...rte_compat.h => rte_function_versioning.h} | 19 +++----------------
> lib/librte_lpm/rte_lpm.c | 1 +
> lib/librte_lpm/rte_lpm.h | 1 -
> lib/librte_lpm/rte_lpm6.c | 1 +
> lib/librte_timer/rte_timer.c | 2 +-
> 10 files changed, 13 insertions(+), 23 deletions(-)
> rename lib/librte_eal/common/include/{rte_compat.h => rte_function_versioning.h} (89%)
>
Apologies, but one of the parts of the split file somehow missed making the
patch. I'll do a v2 soon.