* [dpdk-dev] [PATCH] app/testpmd: fix wrong return value
@ 2019-09-29 3:22 Qi Zhang
2019-09-30 8:23 ` Ye Xiaolong
0 siblings, 1 reply; 3+ messages in thread
From: Qi Zhang @ 2019-09-29 3:22 UTC (permalink / raw)
To: ivan.ilchenko, arybchenko, bernard.iremonger
Cc: xiaolong.ye, simei.su, dev, Qi Zhang
The patch fix the issue that return value in parse_vc_action_rss
be overwritten unexpectly. That cause an rte_flow creation command
with rss action does not work.
For example:
testpmd> flow create 0 ingress pattern eth / ipv4 / end \
actions rss types ipv4 end / end
We will get error "Bad Agument"
Fixes: f5267e485a2a ("app/testpmd: check status of getting ethdev info")
Reported-by: Simei Su <simei.su@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
app/test-pmd/cmdline_flow.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 369426cbd..932bdb98e 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -3549,10 +3549,11 @@ parse_vc_action_rss(struct context *ctx, const struct token *token,
if (!port_id_is_invalid(ctx->port, DISABLED_WARN) &&
ctx->port != (portid_t)RTE_PORT_ALL) {
struct rte_eth_dev_info info;
+ int ret2;
- ret = rte_eth_dev_info_get(ctx->port, &info);
- if (ret != 0)
- return ret;
+ ret2 = rte_eth_dev_info_get(ctx->port, &info);
+ if (ret2 != 0)
+ return ret2;
action_rss_data->conf.key_len =
RTE_MIN(sizeof(action_rss_data->key),
--
2.13.6
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] app/testpmd: fix wrong return value
2019-09-29 3:22 [dpdk-dev] [PATCH] app/testpmd: fix wrong return value Qi Zhang
@ 2019-09-30 8:23 ` Ye Xiaolong
2019-09-30 14:48 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Ye Xiaolong @ 2019-09-30 8:23 UTC (permalink / raw)
To: Qi Zhang; +Cc: ivan.ilchenko, arybchenko, bernard.iremonger, simei.su, dev
On 09/29, Qi Zhang wrote:
>The patch fix the issue that return value in parse_vc_action_rss
>be overwritten unexpectly. That cause an rte_flow creation command
>with rss action does not work.
>
>For example:
>
>testpmd> flow create 0 ingress pattern eth / ipv4 / end \
>actions rss types ipv4 end / end
>
>We will get error "Bad Agument"
>
>Fixes: f5267e485a2a ("app/testpmd: check status of getting ethdev info")
>
>Reported-by: Simei Su <simei.su@intel.com>
>Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
>---
> app/test-pmd/cmdline_flow.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
>index 369426cbd..932bdb98e 100644
>--- a/app/test-pmd/cmdline_flow.c
>+++ b/app/test-pmd/cmdline_flow.c
>@@ -3549,10 +3549,11 @@ parse_vc_action_rss(struct context *ctx, const struct token *token,
> if (!port_id_is_invalid(ctx->port, DISABLED_WARN) &&
> ctx->port != (portid_t)RTE_PORT_ALL) {
> struct rte_eth_dev_info info;
>+ int ret2;
>
>- ret = rte_eth_dev_info_get(ctx->port, &info);
>- if (ret != 0)
>- return ret;
>+ ret2 = rte_eth_dev_info_get(ctx->port, &info);
>+ if (ret2 != 0)
>+ return ret2;
>
> action_rss_data->conf.key_len =
> RTE_MIN(sizeof(action_rss_data->key),
>--
>2.13.6
>
Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] app/testpmd: fix wrong return value
2019-09-30 8:23 ` Ye Xiaolong
@ 2019-09-30 14:48 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2019-09-30 14:48 UTC (permalink / raw)
To: Ye Xiaolong, Qi Zhang
Cc: ivan.ilchenko, arybchenko, bernard.iremonger, simei.su, dev
On 9/30/2019 9:23 AM, Ye Xiaolong wrote:
> On 09/29, Qi Zhang wrote:
>> The patch fix the issue that return value in parse_vc_action_rss
>> be overwritten unexpectly. That cause an rte_flow creation command
>> with rss action does not work.
>>
>> For example:
>>
>> testpmd> flow create 0 ingress pattern eth / ipv4 / end \
>> actions rss types ipv4 end / end
>>
>> We will get error "Bad Agument"
>>
>> Fixes: f5267e485a2a ("app/testpmd: check status of getting ethdev info")
>>
>> Reported-by: Simei Su <simei.su@intel.com>
>> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
>> ---
>> app/test-pmd/cmdline_flow.c | 7 ++++---
>> 1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
>> index 369426cbd..932bdb98e 100644
>> --- a/app/test-pmd/cmdline_flow.c
>> +++ b/app/test-pmd/cmdline_flow.c
>> @@ -3549,10 +3549,11 @@ parse_vc_action_rss(struct context *ctx, const struct token *token,
>> if (!port_id_is_invalid(ctx->port, DISABLED_WARN) &&
>> ctx->port != (portid_t)RTE_PORT_ALL) {
>> struct rte_eth_dev_info info;
>> + int ret2;
>>
>> - ret = rte_eth_dev_info_get(ctx->port, &info);
>> - if (ret != 0)
>> - return ret;
>> + ret2 = rte_eth_dev_info_get(ctx->port, &info);
>> + if (ret2 != 0)
>> + return ret2;
>>
>> action_rss_data->conf.key_len =
>> RTE_MIN(sizeof(action_rss_data->key),
>> --
>> 2.13.6
>>
>
> Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
>
Squashed into relevant commit in next-net, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-30 14:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-29 3:22 [dpdk-dev] [PATCH] app/testpmd: fix wrong return value Qi Zhang
2019-09-30 8:23 ` Ye Xiaolong
2019-09-30 14:48 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).